-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libigl: migrate to Conan v2 #18849
libigl: migrate to Conan v2 #18849
Conversation
valgur
commented
Jul 23, 2023
•
edited
Loading
edited
- Resolves bump libigl #9469
- Resolves [request] libigl/2.4.0 #9694
I detected other pull requests that are modifying libigl/2.x.x recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again. |
This comment has been minimized.
This comment has been minimized.
Hi, thanks for this one. As I see, https://libigl.github.io/static-library/ comes in both header-only and static library, we'll need to model that. For an example on how to, fmt's recipe handles a similar case :) |
This comment has been minimized.
This comment has been minimized.
I've pushed a change to manually override the package_type when header_only - The rest of the PR looks good to me :) |
I lied, now it looks good to me, feel free to take a look and let me know if you agree with my changes @valgur |
Looks good, thanks! |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
e603f4a
to
23e1936
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
70ec6a1
to
27354b5
Compare
aa930d4
to
5875dd0
Compare
This comment has been minimized.
This comment has been minimized.
5875dd0
to
e2e70b5
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline ✔️
All green in build 3 ( |