Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libigl: migrate to Conan v2 #18849

Merged
merged 19 commits into from
May 6, 2024
Merged

Conversation

valgur
Copy link
Contributor

@valgur valgur commented Jul 23, 2023

@ghost
Copy link

ghost commented Jul 23, 2023

I detected other pull requests that are modifying libigl/2.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@valgur
Copy link
Contributor Author

valgur commented Jul 26, 2023

Closing temporarily to avoid unnecessary load on the CI. Will reopen when I'm actively working on the PR again.

@conan-center-bot

This comment has been minimized.

@ghost ghost mentioned this pull request Aug 25, 2023
4 tasks
@AbrilRBS AbrilRBS self-assigned this Sep 4, 2023
@AbrilRBS
Copy link
Member

Hi, thanks for this one. As I see, https://libigl.github.io/static-library/ comes in both header-only and static library, we'll need to model that. For an example on how to, fmt's recipe handles a similar case :)

@conan-center-bot

This comment has been minimized.

@AbrilRBS
Copy link
Member

AbrilRBS commented Oct 2, 2023

I've pushed a change to manually override the package_type when header_only - The rest of the PR looks good to me :)

@AbrilRBS
Copy link
Member

AbrilRBS commented Oct 2, 2023

I lied, now it looks good to me, feel free to take a look and let me know if you agree with my changes @valgur

@valgur
Copy link
Contributor Author

valgur commented Oct 2, 2023

Looks good, thanks!

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@jcar87 jcar87 self-assigned this Feb 9, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (5b25d6690a9c0e30e04a70c83c309aae14e941a8):

  • libigl/2.3.0:
    All packages built successfully! (All logs)

  • libigl/2.5.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (5b25d6690a9c0e30e04a70c83c309aae14e941a8):

  • libigl/2.3.0:
    All packages built successfully! (All logs)

  • libigl/2.5.0:
    All packages built successfully! (All logs)

@valgur valgur requested a review from danimtb April 25, 2024 19:12
@conan-center-bot conan-center-bot merged commit 36696d7 into conan-io:master May 6, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] libigl/2.4.0
7 participants