Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump libigl #9469

Closed
wants to merge 2 commits into from
Closed

Conversation

AndreyMlashkin
Copy link
Contributor

@AndreyMlashkin AndreyMlashkin commented Feb 22, 2022

Specify library name and version: libigl/2.4.0

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AndreyMlashkin
Copy link
Contributor Author

@jgsogo , RAM overrun?

@SSE4 SSE4 added the infrastructure Waiting on tools or services belonging to the infra label Feb 23, 2022
@SSE4
Copy link
Contributor

SSE4 commented Feb 23, 2022

@jgsogo , RAM overrun?

very likely. we'll need to check how much RAM does it need, and move it to the proper pod (large or xlarge).

@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

Can we build with only one core to save some RAM?

https://docs.conan.io/en/latest/reference/build_helpers/cmake.html#constructor

cmake = CMake(self, parallel=False)

@AndreyMlashkin
Copy link
Contributor Author

As I was implementing current version of the lib, I have tried it, but it didn't help...

@svenpilz
Copy link
Contributor

I guess we would also need to change to the new cmake options. Some have been renamed. They provide a list in https://github.com/libigl/libigl/blob/v2.4.0/LibiglOptions.cmake.sample.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Failure in build 4 (939fbdd7311f329fe57731a6758e91352f2a0c63):

  • libigl/2.3.0@:
    An unexpected error happened and has been reported

  • libigl/2.4.0@:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@CLAassistant
Copy link

CLAassistant commented May 18, 2023

CLA assistant check
All committers have signed the CLA.

@ghost ghost mentioned this pull request Jul 23, 2023
@ghost
Copy link

ghost commented Aug 25, 2023

I detected other pull requests that are modifying libigl/2.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@jcar87
Copy link
Contributor

jcar87 commented Feb 9, 2024

Closing in favour of #18849 - thanks for your contribution!

@jcar87 jcar87 closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Failed infrastructure Waiting on tools or services belonging to the infra Unexpected Error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants