Implement functions to generate latest and list of times #53
Conversation
owenfarrell
changed the title
Signed-off-by: Owen Farrell <[email protected]>
owenfarrell
force-pushed
the
lord_calculator
branch
from
db7332b
to
f7984cf
Compare
owenfarrell
changed the title
There was a problem hiding this comment.
Phew! Sorry for the wait on this, lots of life stuff getting in the way lately. Also time related PRs are so tricky to review, haha. (As exemplified by my many notes to self.)
I think this is good to go - the tests look great and make sense to me, and at worst it won't break anything as it's not yet integrated. Merging!
| }), | ||
| Entry("between the start and stop time but the stop time is before the start time, spanning half a day", testCase{ | ||
| start: "8:00 PM +0000", | ||
| stop: "8:00 AM +0000", | ||
| now: "1:00 AM +0000", | ||
| result: true, | ||
| latest: expectedTime{hour: 20, weekday: time.Saturday}, |
There was a problem hiding this comment.
Note to self: this, along with the other examples, expects Saturday because nowDay defaults to 0, i.e. Sunday, and we're returning 8PM on the previous day, i.e. Saturday.
| }), | ||
|
|
||
| Entry("between the start and stop time but the compare time is in a different timezone", testCase{ | ||
| start: "2:00 AM -0600", | ||
| stop: "6:00 AM -0600", | ||
| now: "1:00 AM -0700", | ||
| result: true, | ||
| latest: expectedTime{hour: 8}, |
There was a problem hiding this comment.
Note to self: 8 because it's normalized to UTC, and 2AM + negating the -6 hour offset = 8.
| @@ -294,6 +349,11 @@ var _ = DescribeTable("A range with a location and a previous time", (testCase). | |||
| nowDay: time.Thursday, | |||
|
|
|||
| result: true, | |||
| latest: expectedTime{hour: 13, weekday: time.Thursday}, | |||
| list: []expectedTime{ | |||
| {hour: 13, weekday: time.Wednesday}, | |||
There was a problem hiding this comment.
Note to self: 13 = 1PM in America/Indiana/Indianapolis = 6PM +0000.
| @@ -342,6 +410,11 @@ var _ = DescribeTable("A range with an interval and a previous time", (testCase) | |||
| nowDay: time.Thursday, | |||
|
|
|||
| result: true, | |||
| latest: expectedTime{hour: 13, weekday: time.Thursday}, | |||
| list: []expectedTime{ | |||
| {hour: 14, minute: 58, weekday: time.Wednesday}, | |||
There was a problem hiding this comment.
Note to self: stop is exclusive, so it is correct for this to be the last version.
|
@vito - Thanks for the follow up. And don't sweat the turnaround time, I know there's been lots of activity going on with core capabilities and recognize this isn't as urgent as that work. |
This change adds 2 new functions to the
TimeLordtype:Latest- generates thetime.Timefor which no greater value will also satisfy the configuration. This function may return a zerotime.Timein certain circumstances, such as:PreviousTimeand not inStart/StoprangePreviousTimeis afterreferenceList- generate alltime.Timeinstances which satisfy the configuration between thePreviousTimeand the specifiedreference(inclusive). This function may return an empty list in certain circumstances, such as:PreviousTimeis not rounded to the nearest interval/start-of-rangePreviousTimeis afterreferenceThis PR is marked as a draft until #52 is merged.