Extract business logic to base package #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Owen Farrell <[email protected]>
Signed-off-by: Owen Farrell <[email protected]>
Signed-off-by: Owen Farrell <[email protected]>
owenfarrell
changed the title
Signed-off-by: Owen Farrell <[email protected]>
aoldershaw
approved these changes
Aug 26, 2020
There was a problem hiding this comment.
Looks great to me! I'll leave it for @izabelacg and/or @vito to have a look before merging
|
lgtm! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queuing this one up for awareness.
The goal of this PR is to bring the project structure in line with other resources (e.g. github-release-resource, and more recently the registry-image-resource) which have thinner main functions responsible for deserializing/serializing content from/to the command line.
The longer term need for this change is to support more consistent testing. Unit tests that rely on the
time.Now(), coupled with the additional complexity of #53 and #54, will be a challenge.For the most part, this is a lift-and-shift of existing logic. Changes to unit tests were minimal (i.e. updating
BeforeEachto use the correct types), but some unit tests forcheckwere really testing themodelsand their associated validation. Those tests are now in their own suite as part of themodelspackage.This PR is marked as a draft until #54 is merged.