Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linter hints for issues with OSX configuration in CBC #1929

Merged
merged 8 commits into from
May 13, 2024

Conversation

h-vetinari
Copy link
Member

Linter portion of #1927, but also adding linter hints for warnings from #1889, which were so far only visible when running smithy locally.

@h-vetinari h-vetinari requested a review from a team as a code owner May 13, 2024 02:00
@h-vetinari h-vetinari changed the title Lint osx cbc Add linter hints for issues with OSX configuration in CBC May 13, 2024
@beckermr beckermr merged commit 5bb19bd into conda-forge:main May 13, 2024
2 checks passed
@h-vetinari h-vetinari deleted the lint_osx_cbc branch May 13, 2024 21:12
@maresb
Copy link
Contributor

maresb commented Jun 17, 2024

I was pretty confused about the c_stdlib_version below the current global baseline warning I received here.

After some investigation I realized that it was coming from this file. (It would have been helpful to indicate the filename recipe/conda_build_config.yaml.) I created that file according to this announcement and then forgot about it.

My confusion was because I don't have the bigger picture of what's going on, and when I created conda_build_config.yaml I was blindly following the announcement without fully realizing that I was pinning the c_stdlib_version which might need to be updated in the future. In my case it seemed to work to simply delete the entry from conda_build_config.yaml. Should this be mentioned as another possible resolution? (Also, I hope this was the correct action in my case?)

@h-vetinari
Copy link
Member Author

I was pretty confused about the c_stdlib_version below the current global baseline warning I received here.

Sorry about that...

In my case it seemed to work to simply delete the entry from conda_build_config.yaml. Should this be mentioned as another possible resolution?

PRs to improve the warning messages here (or documentation), so that they would have been more understandable to you, would be greatly appreciated!

Also, I hope this was the correct action in my case?

Yes, deleting a pin for c_stdlib_version <10.13 is completely fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants