Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: robustify CBC linter w.r.t. or'd selectors #1939

Merged
merged 3 commits into from
May 24, 2024

Conversation

h-vetinari
Copy link
Member

For #1929, we needed to do some basic filtering in CBC to the platform we're looking at, in order to not produce spurious warnings. In order to keep things simple and not rewrite too much of conda-build, this was done with some simple-ish regex pattern, that however wasn't smart enough to deal with or-conjunctions.

I've recently hit a linter bug on the otherwise benign

c_stdlib_version:  # [linux or (osx and x86_64)]
  - 2.17           # [linux]
  - 10.15          # [osx and x86_64]

and this is something we shouldn't fail on. I know how to work around it, but only because I wrote the linter rule 😅

Fortunately, there is a simple fix that occurred to me: just don't filter out any of the yaml keys.

@h-vetinari h-vetinari requested a review from a team as a code owner May 24, 2024 05:01
@beckermr beckermr merged commit 277413a into conda-forge:main May 24, 2024
2 checks passed
@h-vetinari h-vetinari deleted the fix_lint branch May 24, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants