-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump to 3.1.0 #26
Bump to 3.1.0 #26
Conversation
Bump the recipe to triton 3.1.0, using the commit referenced in PyTorch's .ci/docker/ci_commit_pins/triton.txt (since upstream did not tag the release). Backport a few patches to make it compatible with LLVM/MLIR 19, as the 3.1.0 release was made against a mailine commit between LLVM 18 and 19, and does not work with either of these versions. TODO: unvendor nvidia components
…nda-forge-pinning 2024.11.20.13.33.43
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipe/meta.yaml:
For recipe/meta.yaml:
|
…nda-forge-pinning 2024.11.21.05.29.27
Ok, so the problem with LLVM is that the build system somehow manages to simultaneously link to static and shared LLVM libraries, which results in duplicate symbols. My quick attempt to use just shared libraries fails, so instead I need to figure out where the shared libraries are coming from. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This package requires nvcc, so at least 12.0+, and it fails to compile against 12.0. Upstream uses 12.4.99 in this release.
…nda-forge-pinning 2024.11.21.16.17.13
A quick summary (roughly the same details as in comments and commit messages):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good already, thanks a lot. Some questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
Hi! This is the friendly conda-forge automerge bot! I considered the following status checks when analyzing this PR:
Thus the PR was passing and merged! Have a great day! |
Thanks! |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Managed to unvendor LLVM and make it build against LLVM 19 but it fails to run:
I've seen it before, I'll think about it more tomorrow. I still need to unvendor NVidia dependencies too.