Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for CUDA 12.6 and finding CUDA tools #28

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Nov 26, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

Unfortunately, my testing of #26 was insufficient, and more complex testing with PyTorch revealed more issues. This pull request:

  1. Backports an upstream patch enabling support for CUDA 12.6.
  2. Fixes tool path lookup to use PATH, to find tools installed in CONDA_PREFIX.
  3. Adds a minimal pytest invocation that would have caught the two aforementioned bugs.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

Copy link
Member

@h-vetinari h-vetinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@h-vetinari h-vetinari merged commit cd15807 into conda-forge:main Nov 26, 2024
8 checks passed
@mgorny mgorny deleted the cuda-12.6 branch November 27, 2024 04:22
@mgorny
Copy link
Contributor Author

mgorny commented Nov 27, 2024

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants