Skip to content

Commit

Permalink
fix(typing): 'axios' import in typings (#218)
Browse files Browse the repository at this point in the history
We correctly import `axios` in the type definitions `index.d.ts`.

To ensure that typings are checked on CI we run `npm run
test-typescript-declaration`. This requires us to upgrade typescript to
the latest version.
  • Loading branch information
Thomas Scholtes authored and Khaledgarbaya committed Sep 23, 2019
1 parent da792be commit 6e8b033
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ env:
script:
- npm run lint
- npm run build-dev
- npm run test-typescript-declaration
- npm run coverage-report

cache:
Expand Down
2 changes: 1 addition & 1 deletion index.d.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import axios from 'axios'
import * as axios from 'axios'

export interface Movement {
toTheTop(): void
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@
"ts-node": "^3.3.0",
"tslint": "^5.7.0",
"tslint-config-standard": "^6.0.1",
"typescript": "^2.5.3",
"typescript": "^3.5.3",
"uuid": "^3.3.2",
"zlib": "^1.0.5"
},
Expand Down

0 comments on commit 6e8b033

Please sign in to comment.