fix(typing): 'axios' import in typings #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We correctly import `axios` in the type definitions `index.d.ts`. To ensure that typings are checked on CI we run `npm run test-typescript-declaration`. This requires us to upgrade typescript to the latest version.
Khaledgarbaya
suggested changes
Aug 13, 2019
|
@Khaledgarbaya Any update on this? |
Khaledgarbaya
changed the title
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We correctly import
axiosin the type definitionsindex.d.ts.To ensure that typings are checked on CI we run
npm run test-typescript-declaration. This requires us to upgrade typescript to the latest version.