idl: Fix using address
constraint with non-const expressions
#3216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
IDL generation fails if you use non-const expressions with the
address
constraint:We had a similar problem in #2912, but that was only specific to field expressions and was fixed in #3034.
Summary of changes
Rather than assuming all expressions (other than field expressions) are valid for the
address
field (in the IDL), only assume the following expressions are valid:const
) e.g.my_program::ID
const fn
) e.g.my_program::id()
For everything else, skip the
address
field resolution.