Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation has outdated code-snippets #8750

Closed
4 tasks
pashashocky opened this issue Mar 2, 2021 · 3 comments · Fixed by #8751
Closed
4 tasks

Documentation has outdated code-snippets #8750

pashashocky opened this issue Mar 2, 2021 · 3 comments · Fixed by #8751
Labels
T:Docs Changes and features related to documentation.

Comments

@pashashocky
Copy link
Contributor

pashashocky commented Mar 2, 2021 •
edited
Loading

Documentation has outdated code snippets [stargate]

I'm reading through the documentation on docs.cosmos.network and finding a lot of some mismatching code-snippets.
I'll be fixing them as I go through reading the docs and will make a PR to fix these.

v0.41.3

Steps to Reproduce

e.g.: https://docs.cosmos.network/v0.41/basics/app-anatomy.html#initchainer

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@pashashocky pashashocky mentioned this issue Mar 2, 2021
Merged
9 tasks
@clevinson
Copy link
Contributor

Thanks for filing and taking a look at this @pashashocky !

Please tag myself or @AmauryM in the PR when its ready for review.

@clevinson clevinson added the T:Docs Changes and features related to documentation. label Mar 2, 2021
@pashashocky
Copy link
Contributor Author

pashashocky commented Mar 4, 2021 •
edited
Loading

Thanks for filing and taking a look at this @pashashocky !

Please tag myself or @AmauryM in the PR when its ready for review.

Not sure what the last snippet of OCAPS should be here - would appreciate a hint :)
http://localhost:8080/core/ocap.html#ocaps-in-practice

Couldn't find any pass by value to external modules...

@amaury1093
Copy link
Contributor

lol, no idea either...

I think just linking to simapp's keepers should be good enough: https://github.com/cosmos/cosmos-sdk/blob/v0.41.4/simapp/app.go#L249

We're anyway re-thinking the OCAPS system in adr-033

@mergify mergify bot closed this as completed in #8751 Mar 16, 2021
alessio pushed a commit that referenced this issue Mar 16, 2021
@mergify @pashashocky @amaury1093
Update docs (bp #8751) (#8894)
51b163e 
closes: #8750

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 36f68eb)

Co-authored-by: Pash <[email protected]>
Co-authored-by: Amaury M <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update docs
3 participants
@pashashocky @clevinson @amaury1093