Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #8751

Merged
merged 11 commits into from
Mar 16, 2021
Merged

Update docs #8751

merged 11 commits into from
Mar 16, 2021

Conversation

pashashocky
Copy link
Contributor

@pashashocky pashashocky commented Mar 2, 2021

Description

Solely documentation updates to the outdated code snippets, and those that do not match description.

closes: #8750


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@pashashocky
Copy link
Contributor Author

@clevinson @AmauryM this looks good to be merged in my eyes. I skimmed over the IBC, Running a Node and Migration sections - couldn't find anything obvious there, although it will take a while until I would need to use those.

Basics, Core and Building Modules I read in detail, so hopefully picked up everything.

@pashashocky pashashocky marked this pull request as ready for review March 6, 2021 14:08
@amaury1093 amaury1093 added backport/0.42.x (Stargate) T:Docs Changes and features related to documentation. labels Mar 8, 2021
@aaronc aaronc requested review from amaury1093 and clevinson March 8, 2021 15:23
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. I randomly checked 3 links, they all link to correct snippets.

@amaury1093 amaury1093 requested a review from tac0turtle March 16, 2021 12:09
@amaury1093 amaury1093 added the A:automerge Automatically merge PR once all prerequisites pass. label Mar 16, 2021
@mergify mergify bot merged commit 36f68eb into cosmos:master Mar 16, 2021
mergify bot pushed a commit that referenced this pull request Mar 16, 2021
* docs/basics/app-anatomy.md: update code snippets

* Update outdated code snippets

* docs/basics/accounts.md: update code snippets

* Update outdated code snippets

* docs/core/baseapp.md: update code snippets

* Update outdated code snippets

* docs/core/node.md: update code snippets

* Update outdated code snippets

* docs/core/store.md: fixed typos

* docs/core/grpc_rest.md: fix typos

* docs/core/cli.md: fix typos

* docs/core/ocap.md: fix code snippet

* docs/building-modules/msg-services.md: fix snippet

* Update stale code snippets

* docs/building-modules/simulator.md: snippets fix

* Update outdated code snippet

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 36f68eb)

# Conflicts:
#	docs/basics/app-anatomy.md
@mergify mergify bot mentioned this pull request Mar 16, 2021
alessio pushed a commit that referenced this pull request Mar 16, 2021
closes: #8750

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit 36f68eb)

Co-authored-by: Pash <[email protected]>
Co-authored-by: Amaury M <[email protected]>
@pashashocky pashashocky deleted the updateDocs branch March 19, 2021 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation has outdated code-snippets
3 participants