Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate x/crisis use app wiring #12389

Merged
merged 5 commits into from
Jun 30, 2022

Conversation

julienrbrt
Copy link
Member

Description

Ports #12270 to main
cc @JeancarloBarrios


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

protoiface "google.golang.org/protobuf/runtime/protoiface"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
io "io"
reflect "reflect"

Check notice

Code scanning / CodeQL

Sensitive package import

Certain system packages contain functions which may be a possible source of non-determinism
@julienrbrt julienrbrt force-pushed the JeancarloBarrios/migrate_crisis_use_app_wiring branch from 8cd4e0c to 8c86f49 Compare June 30, 2022 11:13
@github-actions github-actions bot added C:x/auth C:x/distribution distribution module related labels Jun 30, 2022
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for @julienrbrt :)

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #12389 (345ca3f) into main (17dc431) will decrease coverage by 0.01%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12389      +/-   ##
==========================================
- Coverage   65.68%   65.67%   -0.02%     
==========================================
  Files         676      676              
  Lines       71456    71467      +11     
==========================================
- Hits        46939    46938       -1     
- Misses      21879    21892      +13     
+ Partials     2638     2637       -1     
Impacted Files Coverage Δ
simapp/simd/cmd/root.go 69.42% <0.00%> (-1.77%) ⬇️
x/crisis/keeper/msg_server.go 0.00% <0.00%> (ø)
x/slashing/module.go 69.31% <ø> (ø)
simapp/test_helpers.go 15.96% <14.28%> (-0.35%) ⬇️
x/crisis/keeper/genesis.go 40.00% <50.00%> (ø)
x/crisis/keeper/params.go 40.00% <50.00%> (ø)
x/crisis/keeper/keeper.go 81.81% <75.00%> (ø)
simapp/app.go 75.00% <100.00%> (-1.12%) ⬇️
testutil/network/network.go 56.67% <100.00%> (ø)
x/distribution/module.go 56.17% <100.00%> (+2.06%) ⬆️
... and 2 more

@julienrbrt julienrbrt merged commit 77cf430 into main Jun 30, 2022
@julienrbrt julienrbrt deleted the JeancarloBarrios/migrate_crisis_use_app_wiring branch June 30, 2022 15:57
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants