Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: CollectStdTxs() must check DelegatorAddr against accounts #3004

Merged
merged 2 commits into from
Dec 5, 2018

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Dec 5, 2018

Closes: #3003

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

cmd/gaia/app/genesis.go Outdated Show resolved Hide resolved
cmd/gaia/app/genesis.go Outdated Show resolved Hide resolved
cmd/gaia/app/genesis.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #3004 into develop will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3004      +/-   ##
===========================================
- Coverage    55.53%   55.51%   -0.03%     
===========================================
  Files          120      120              
  Lines         8490     8490              
===========================================
- Hits          4715     4713       -2     
- Misses        3453     3455       +2     
  Partials       322      322

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM 👍

Not sure if this warrants a new test/test case.

Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! good improvement @alessio. If there is a test case here could you add it too? Otherwise gets a 👍 from me!

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK, a testcase would be nice (maybe we should wait on the CLI testcase refactor though).

@jackzampolin jackzampolin merged commit 8162489 into develop Dec 5, 2018
@jackzampolin jackzampolin deleted the alessio/3003-collect-stdtx-delegator-addr branch December 5, 2018 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants