-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
R4R: CollectStdTxs() must check DelegatorAddr against accounts #3004
R4R: CollectStdTxs() must check DelegatorAddr against accounts #3004
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3004 +/- ##
===========================================
- Coverage 55.53% 55.51% -0.03%
===========================================
Files 120 120
Lines 8490 8490
===========================================
- Hits 4715 4713 -2
- Misses 3453 3455 +2
Partials 322 322 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM 👍
Not sure if this warrants a new test/test case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! good improvement @alessio. If there is a test case here could you add it too? Otherwise gets a 👍 from me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested ACK, a testcase would be nice (maybe we should wait on the CLI testcase refactor though).
Closes: #3003
docs/
)PENDING.md
with issue #Files changed
in the github PR explorerFor Admin Use: