R4R: Make more validate about the MsgCreateValidator in CollectStdTxs
#853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haifengxi
requested review from
HaoyangLiu,
MrXJC and
wukongcheng
and removed request for
HaoyangLiu
wukongcheng
reviewed
Dec 19, 2018
modules/auth/stdtx.go
Outdated
| var ( | ||
| _ sdk.Tx = (*StdTx)(nil) | ||
|
|
||
| maxGasWanted = uint64((1 << 63) - 1) |
There was a problem hiding this comment.
uint64((1 << 63) - 1) --> math.MaxInt64
wukongcheng
reviewed
Dec 19, 2018
modules/auth/stdtx.go
Outdated
|
|
||
| if tx.Fee.Gas > maxGasWanted { | ||
| return sdk.ErrGasOverflow(fmt.Sprintf("invalid gas supplied; %d > %d", tx.Fee.Gas, maxGasWanted)) | ||
| } |
There was a problem hiding this comment.
change the tendermint to use uint64 for gas instead of int64
wukongcheng
suggested changes
Dec 19, 2018
|
We have checked gas overflow in FeePreprocessHandler, so I removed the relevant commits. |
wukongcheng
approved these changes
Dec 20, 2018
wukongcheng
changed the title
MsgCreateValidator in CollectStdTxs
MrXJC
approved these changes
Dec 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R4R: CollectStdTxs() must check DelegatorAddr against accounts cosmos/cosmos-sdk#3004