Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R4R: Check for gas overflow in tx validation #3070

Merged
merged 2 commits into from
Dec 10, 2018

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Dec 10, 2018

closes #3068


  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added entries in PENDING.md with issue #

  • rereviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

x/auth/stdtx.go Outdated Show resolved Hide resolved
Copy link
Contributor

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the first issue! I still need to make an issue for the second case, will do after tm meeting.

@codecov
Copy link

codecov bot commented Dec 10, 2018

Codecov Report

Merging #3070 into develop will increase coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #3070      +/-   ##
===========================================
+ Coverage    52.16%   52.17%   +<.01%     
===========================================
  Files          136      136              
  Lines         9612     9614       +2     
===========================================
+ Hits          5014     5016       +2     
  Misses        4262     4262              
  Partials       336      336

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

overflow in gas wanted conversion can cause txs to have negative gas on tm side
3 participants