Merge pull request #3 from cosywasswa/validations

Milestone: #validations and model specs

.rspec

@@ -0,0 +1 @@
+--require spec_helper

Gemfile

@@ -5,6 +5,8 @@ ruby '3.2.2'
 
 gem 'rubocop', '>= 1.0', '< 2.0'
 
+gem 'rspec-rails'
+
 # Bundle edge Rails instead: gem "rails", github: "rails/rails", branch: "main"
 gem 'rails', '~> 7.0.8'
 

Gemfile.lock

@@ -89,6 +89,7 @@ GEM
     debug (1.8.0)
       irb (>= 1.5.0)
       reline (>= 0.3.1)
+    diff-lcs (1.5.0)
     erubi (1.12.0)
     globalid (1.2.1)
       activesupport (>= 6.1)
@@ -182,6 +183,23 @@ GEM
     reline (0.3.8)
       io-console (~> 0.5)
     rexml (3.2.6)
+    rspec-core (3.12.2)
+      rspec-support (~> 3.12.0)
+    rspec-expectations (3.12.3)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.12.0)
+    rspec-mocks (3.12.6)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.12.0)
+    rspec-rails (6.0.3)
+      actionpack (>= 6.1)
+      activesupport (>= 6.1)
+      railties (>= 6.1)
+      rspec-core (~> 3.12)
+      rspec-expectations (~> 3.12)
+      rspec-mocks (~> 3.12)
+      rspec-support (~> 3.12)
+    rspec-support (3.12.1)
     rubocop (1.56.3)
       base64 (~> 0.1.1)
       json (~> 2.3)
@@ -248,6 +266,7 @@ DEPENDENCIES
   pg (~> 1.1)
   puma (~> 5.0)
   rails (~> 7.0.8)
+  rspec-rails
   rubocop (>= 1.0, < 2.0)
   selenium-webdriver
   sprockets-rails

README.md

@@ -49,6 +49,7 @@ Blog-app is a fully functioning website that show the list of posts and empower
 - **Create Database named Blog_app_development**
 - **Create tables by migration files**
 - **processing data in models**
+- **Validations and Model specs**
 
 <p align="right">(<a href="#readme-top">back to top</a>)</p>
 
@@ -67,6 +68,7 @@ In order to run this project you need:
     rails
     postgresql
     bundler
+    rspec
 ```
 
 ### Setup
@@ -106,7 +108,6 @@ it will install the required gemfile for running the project
 <!-- FUTURE FEATURES -->
 
 ## 🔭 Future Features <a name="future-features"></a>
- - Validations and Model specs.
  - Controllers.
  - Controllers specs.
  - Views.

app/models/comment.rb

@@ -4,5 +4,6 @@ class Comment < ApplicationRecord
 
   def update_post_comments_counter
     post.update(comments_counter: post.comments.count)
+    post.comments.count
   end
 end

app/models/like.rb

@@ -4,5 +4,6 @@ class Like < ApplicationRecord
 
   def update_post_likes_counter
     post.update(likes_counter: post.likes.count)
+    post.likes.count
   end
 end

app/models/post.rb

@@ -3,8 +3,13 @@ class Post < ApplicationRecord
   has_many :comments, foreign_key: 'post_id'
   has_many :likes, foreign_key: 'post_id'
 
+  validates :title, presence: true, length: { maximum: 250 }
+  validates :comments_counter, numericality: { only_integer: true, greater_than_or_equal_to: 0 }
+  validates :likes_counter, numericality: { only_integer: true, greater_than_or_equal_to: 0 }
+
   def update_user_posts_counter
     author.update(posts_counter: author.posts.count)
+    author.posts.count
   end
 
   def recent_comments(limit = 5)

app/models/user.rb

@@ -3,6 +3,9 @@ class User < ApplicationRecord
   has_many :comments, foreign_key: 'user_id'
   has_many :likes, foreign_key: 'user_id'
 
+  validates :name, presence: true
+  validates :posts_counter, numericality: { only_integer: true, greater_than_or_equal_to: 0 }
+
   def recent_posts(limit = 3)
     posts.order(created_at: :desc).limit(limit)
   end

spec/comment_spec.rb

@@ -0,0 +1,26 @@
+require 'rails_helper'
+
+RSpec.describe Comment, type: :Model do
+  let(:user) { User.new(name: 'Cosmas', photo: 'www.newpics.com/jpg', bio: 'First son', posts_counter: 4) }
+  before { user.save }
+
+  let(:post) do
+    Post.new(title: 'greeting', text: 'Nice photos sofar', comments_counter: 2, likes_counter: 10, author_id: user.id)
+  end
+  before { post.save }
+
+  let(:comment) { Comment.new(text: 'hey brother', user_id: user.id, post_id: post.id) }
+  before { comment.save }
+
+  describe '#update_post_comments_counter' do
+    it 'should return correct number of comments' do
+      counter = comment.update_post_comments_counter
+      expect(counter).to eq(1)
+    end
+    it 'should return two comments after adding a second comment' do
+      Comment.create(text: 'hey here is the second', user_id: user.id, post_id: post.id)
+      counter = comment.update_post_comments_counter
+      expect(counter).to eq(2)
+    end
+  end
+end

spec/like_spec.rb

@@ -0,0 +1,23 @@
+require 'rails_helper'
+
+RSpec.describe Like, type: :Model do
+  let(:user) { User.new(name: 'Cosmas', photo: 'www.newpics.com/jpg', bio: 'First son', posts_counter: 0) }
+  before { user.save }
+
+  let(:post) do
+    Post.new(title: 'greeting', text: 'Nice photos sofar', comments_counter: 0, likes_counter: 0, author_id: user.id)
+  end
+  before { post.save }
+
+  describe '#update_post_likes_counter' do
+    it 'should return correct number of likes' do
+      like = Like.create(user_id: user.id, post_id: post.id)
+      Like.create(user_id: user.id, post_id: post.id)
+      Like.create(user_id: user.id, post_id: post.id)
+      Like.create(user_id: user.id, post_id: post.id)
+
+      counter = like.update_post_likes_counter
+      expect(counter).to eq(4)
+    end
+  end
+end

spec/post_spec.rb

@@ -0,0 +1,66 @@
+require 'rails_helper'
+
+RSpec.describe Post, type: :Model do
+  let(:user) { User.new(name: 'Cosmas', photo: 'www.newpics.com/jpg', bio: 'First son', posts_counter: 4) }
+  before { user.save }
+
+  let(:post) do
+    Post.new(title: 'greeting', text: 'Nice photos sofar', comments_counter: 2, likes_counter: 10, author_id: user.id)
+  end
+  before { post.save }
+
+  it 'title should be present' do
+    post.title = nil
+    expect(post).to_not be_valid
+  end
+  it 'title should not exceede 250 characters' do
+    post.title = 'b' * 260
+    expect(post).to_not be_valid
+  end
+  it 'comments_counter should be an integer' do
+    post.comments_counter = 'a'
+    expect(post).to_not be_valid
+  end
+  it 'comments_counter should be greater or equal to zero' do
+    post.comments_counter = -2
+    expect(post).to_not be_valid
+  end
+  it 'likes_counter should be an integer' do
+    post.likes_counter = 'k'
+    expect(post).to_not be_valid
+  end
+  it 'likes_counter should be greater or equal to zero' do
+    post.likes_counter = -4
+    expect(post).to_not be_valid
+  end
+  describe '#update_user_posts_counter' do
+    it 'should record the posts counter' do
+      counter = post.update_user_posts_counter
+      expect(counter).to eq(1)
+    end
+  end
+  describe '#recent_comments' do
+    it 'it should return 5 recent comments' do
+      Comment.create(text: 'hey budy', user_id: user.id, post_id: post.id)
+      Comment.create(text: 'hey budy2', user_id: user.id, post_id: post.id)
+      Comment.create(text: 'hey budy3', user_id: user.id, post_id: post.id)
+      Comment.create(text: 'hey budy4', user_id: user.id, post_id: post.id)
+      Comment.create(text: 'hey budy5', user_id: user.id, post_id: post.id)
+      Comment.create(text: 'hey budy6', user_id: user.id, post_id: post.id)
+      Comment.create(text: 'hey budy7', user_id: user.id, post_id: post.id)
+      my_comments = post.recent_comments
+      expect(my_comments.length).to eq(5)
+    end
+    it 'it should return 5 recent comments' do
+      Comment.create(text: 'hey budy', user_id: user.id, post_id: post.id)
+      Comment.create(text: 'hey budy2', user_id: user.id, post_id: post.id)
+      Comment.create(text: 'hey budy3', user_id: user.id, post_id: post.id)
+      Comment.create(text: 'hey budy4', user_id: user.id, post_id: post.id)
+      Comment.create(text: 'hey budy5', user_id: user.id, post_id: post.id)
+      Comment.create(text: 'hey budy6', user_id: user.id, post_id: post.id)
+      Comment.create(text: 'hey budy7', user_id: user.id, post_id: post.id)
+      my_comments = post.recent_comments
+      expect(my_comments.first.text).to eq('hey budy7')
+    end
+  end
+end

spec/rails_helper.rb

@@ -0,0 +1,63 @@
+# This file is copied to spec/ when you run 'rails generate rspec:install'
+require 'spec_helper'
+ENV['RAILS_ENV'] ||= 'test'
+require_relative '../config/environment'
+# Prevent database truncation if the environment is production
+abort('The Rails environment is running in production mode!') if Rails.env.production?
+require 'rspec/rails'
+# Add additional requires below this line. Rails is not loaded until this point!
+
+# Requires supporting ruby files with custom matchers and macros, etc, in
+# spec/support/ and its subdirectories. Files matching `spec/**/*_spec.rb` are
+# run as spec files by default. This means that files in spec/support that end
+# in _spec.rb will both be required and run as specs, causing the specs to be
+# run twice. It is recommended that you do not name files matching this glob to
+# end with _spec.rb. You can configure this pattern with the --pattern
+# option on the command line or in ~/.rspec, .rspec or `.rspec-local`.
+#
+# The following line is provided for convenience purposes. It has the downside
+# of increasing the boot-up time by auto-requiring all files in the support
+# directory. Alternatively, in the individual `*_spec.rb` files, manually
+# require only the support files necessary.
+#
+# Dir[Rails.root.join('spec', 'support', '**', '*.rb')].sort.each { |f| require f }
+
+# Checks for pending migrations and applies them before tests are run.
+# If you are not using ActiveRecord, you can remove these lines.
+begin
+  ActiveRecord::Migration.maintain_test_schema!
+rescue ActiveRecord::PendingMigrationError => e
+  abort e.to_s.strip
+end
+RSpec.configure do |config|
+  # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
+  config.fixture_path = "#{Rails.root}/spec/fixtures"
+
+  # If you're not using ActiveRecord, or you'd prefer not to run each of your
+  # examples within a transaction, remove the following line or assign false
+  # instead of true.
+  config.use_transactional_fixtures = true
+
+  # You can uncomment this line to turn off ActiveRecord support entirely.
+  # config.use_active_record = false
+
+  # RSpec Rails can automatically mix in different behaviours to your tests
+  # based on their file location, for example enabling you to call `get` and
+  # `post` in specs under `spec/controllers`.
+  #
+  # You can disable this behaviour by removing the line below, and instead
+  # explicitly tag your specs with their type, e.g.:
+  #
+  #     RSpec.describe UsersController, type: :controller do
+  #       # ...
+  #     end
+  #
+  # The different available types are documented in the features, such as in
+  # https://rspec.info/features/6-0/rspec-rails
+  config.infer_spec_type_from_file_location!
+
+  # Filter lines from Rails gems in backtraces.
+  config.filter_rails_from_backtrace!
+  # arbitrary gems may also be filtered via:
+  # config.filter_gems_from_backtrace("gem name")
+end

spec/spec_helper.rb

@@ -0,0 +1,96 @@
+# This file was generated by the `rails generate rspec:install` command. Conventionally, all
+# specs live under a `spec` directory, which RSpec adds to the `$LOAD_PATH`.
+# The generated `.rspec` file contains `--require spec_helper` which will cause
+# this file to always be loaded, without a need to explicitly require it in any
+# files.
+#
+# Given that it is always loaded, you are encouraged to keep this file as
+# light-weight as possible. Requiring heavyweight dependencies from this file
+# will add to the boot time of your test suite on EVERY test run, even for an
+# individual file that may not need all of that loaded. Instead, consider making
+# a separate helper file that requires the additional dependencies and performs
+# the additional setup, and require it from the spec files that actually need
+# it.
+#
+# See https://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
+RSpec.configure do |config|
+  # rspec-expectations config goes here. You can use an alternate
+  # assertion/expectation library such as wrong or the stdlib/minitest
+  # assertions if you prefer.
+  config.expect_with :rspec do |expectations|
+    # This option will default to `true` in RSpec 4. It makes the `description`
+    # and `failure_message` of custom matchers include text for helper methods
+    # defined using `chain`, e.g.:
+    #     be_bigger_than(2).and_smaller_than(4).description
+    #     # => "be bigger than 2 and smaller than 4"
+    # ...rather than:
+    #     # => "be bigger than 2"
+    expectations.include_chain_clauses_in_custom_matcher_descriptions = true
+  end
+
+  # rspec-mocks config goes here. You can use an alternate test double
+  # library (such as bogus or mocha) by changing the `mock_with` option here.
+  config.mock_with :rspec do |mocks|
+    # Prevents you from mocking or stubbing a method that does not exist on
+    # a real object. This is generally recommended, and will default to
+    # `true` in RSpec 4.
+    mocks.verify_partial_doubles = true
+  end
+
+  # This option will default to `:apply_to_host_groups` in RSpec 4 (and will
+  # have no way to turn it off -- the option exists only for backwards
+  # compatibility in RSpec 3). It causes shared context metadata to be
+  # inherited by the metadata hash of host groups and examples, rather than
+  # triggering implicit auto-inclusion in groups with matching metadata.
+  config.shared_context_metadata_behavior = :apply_to_host_groups
+
+  # The settings below are suggested to provide a good initial experience
+  # with RSpec, but feel free to customize to your heart's content.
+  #   # This allows you to limit a spec run to individual examples or groups
+  #   # you care about by tagging them with `:focus` metadata. When nothing
+  #   # is tagged with `:focus`, all examples get run. RSpec also provides
+  #   # aliases for `it`, `describe`, and `context` that include `:focus`
+  #   # metadata: `fit`, `fdescribe` and `fcontext`, respectively.
+  #   config.filter_run_when_matching :focus
+  #
+  #   # Allows RSpec to persist some state between runs in order to support
+  #   # the `--only-failures` and `--next-failure` CLI options. We recommend
+  #   # you configure your source control system to ignore this file.
+  #   config.example_status_persistence_file_path = "spec/examples.txt"
+  #
+  #   # Limits the available syntax to the non-monkey patched syntax that is
+  #   # recommended. For more details, see:
+  #   # https://rspec.info/features/3-12/rspec-core/configuration/zero-monkey-patching-mode/
+  #   config.disable_monkey_patching!
+  #
+  #   # This setting enables warnings. It's recommended, but in some cases may
+  #   # be too noisy due to issues in dependencies.
+  #   config.warnings = true
+  #
+  #   # Many RSpec users commonly either run the entire suite or an individual
+  #   # file, and it's useful to allow more verbose output when running an
+  #   # individual spec file.
+  #   if config.files_to_run.one?
+  #     # Use the documentation formatter for detailed output,
+  #     # unless a formatter has already been configured
+  #     # (e.g. via a command-line flag).
+  #     config.default_formatter = "doc"
+  #   end
+  #
+  #   # Print the 10 slowest examples and example groups at the
+  #   # end of the spec run, to help surface which specs are running
+  #   # particularly slow.
+  #   config.profile_examples = 10
+  #
+  #   # Run specs in random order to surface order dependencies. If you find an
+  #   # order dependency and want to debug it, you can fix the order by providing
+  #   # the seed, which is printed after each run.
+  #   #     --seed 1234
+  #   config.order = :random
+  #
+  #   # Seed global randomization in this process using the `--seed` CLI option.
+  #   # Setting this allows you to use `--seed` to deterministically reproduce
+  #   # test failures related to randomization by passing the same `--seed` value
+  #   # as the one that triggered the failure.
+  #   Kernel.srand config.seed
+end