Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone: #validations and model specs #3

Merged
merged 13 commits into from
Sep 19, 2023
Merged

Milestone: #validations and model specs #3

merged 13 commits into from
Sep 19, 2023

Conversation

cosywasswa
Copy link
Owner

👇 I completed the following tasks.

  • Added the following validations:
    User Model

  • Name must not be blank

  • PostsCounter must be an integer greater than or equal to zero
    Post model

  • Title must not be blank

  • Title must not exceed 250 characters

  • CommentsCounter must be an integer greater than or equal to zero

  • LikesCounter must be an integer greater than or equal to zero

  • Added unit specs for all the models' methods and validations

  • Updated README with project updates

  • Fixed linter bugs

Copy link

@IngDavidTM IngDavidTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cosywasswa 🙋‍♂️,

✔️ Status: APPROVED 🏆 🎉 🎊

You have done a great job on this project, keep it up 👍 🥇. Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉💯🌟

Top highlight 🎯

  • The Pull Request follows the GitFlow ✅
  • The PR title and description are professional and descriptive ✅
  • Linters are working properly ✅
  • The tests are passing ✅

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@cosywasswa
Copy link
Owner Author

thanks @IngDavidTM

@cosywasswa cosywasswa merged commit 8aa4ed9 into develop Sep 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants