Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test to check all supported protocols are supported in `decodeToState() #1067

Closed
crankyoldgit opened this issue Mar 23, 2020 · 2 comments · Fixed by #1068
Closed

Add unit test to check all supported protocols are supported in `decodeToState() #1067

crankyoldgit opened this issue Mar 23, 2020 · 2 comments · Fixed by #1068
Assignees
@crankyoldgit
Labels
enhancement

Comments

@crankyoldgit
Copy link
Owner

@crankyoldgit Hi, if I use IRMQTTServer, it seems like doesn't transmit to the correct mqtt topic, so the home assistant will not update the cliamte state.

ir_server/received 77,0xAC22808016352216,64
ir_server/received 77,0x5522808016372216,64
ir_server/received 77,0x6523808016372216,64

Originally posted by @chongkk in #1064 (comment)

Seems I miss this step occasionally. Add a unit test that cycles through all the IRac::isProtocolSupported() protocols to confirm there is corresponding IRAcUtils::decodeToState() functionality.
@crankyoldgit crankyoldgit self-assigned this Mar 23, 2020
crankyoldgit added a commit that referenced this issue Mar 23, 2020
@crankyoldgit
Add decodeToState() unit tests to all supported protocols
c5b6644 
Add Unit tests where possible to all protocols. Some in multiple places.
Fixes #1067
@crankyoldgit
Copy link
Owner Author

Due to the structure of the AC classes, you can't just loop over IRac::sendAc() to produce real messages to decode via IRAcUtils::decodeToState(), so I added a test manually for each protocol.
Hopefully I won't forget in future, especially when I copy code from other test cases. :)

@crankyoldgit crankyoldgit mentioned this issue Mar 24, 2020
Merged
crankyoldgit added a commit that referenced this issue Mar 25, 2020
@crankyoldgit
Add decodeToState() unit tests to all supported protocols (#1068)
f0a9a72 
Add Unit tests where possible to all protocols. Some in multiple places.
Fixes #1067
crankyoldgit added a commit that referenced this issue Apr 9, 2020
@crankyoldgit
v2.7.5 Release
a82e664 
_v2.7.5 (20200409)_

**[Features]**
- Detailed support for `HITACHI_AC1` protocol. (#1056, #1061, #1072)
- update sharp to match Sharp AH-A5SAY (#1074)
- Experimental support for AIRWELL protocol. (#1069, #1070)
- SamsungAC: Add Breeze (Aka WindFree) control (#1062, #1071)
- Support for Daikin FFN-C A/C (#1064, #1065)
- Add basic support for HITACHI_AC3 protocol. (#1060, #1063)
- Add support for `SYMPHONY` 11 bit protocol. (#1057, #1058)
- IRMQTTServer: Improve Home-Assistant discovery by sending a 'device' with the discovery packet (#1055)

**[Misc]**
- Clean up support status of various protocols.
- Add `decodeToState()` unit tests to all supported protocols (#1067, #1068)
- Add Gree AC example code. (#1066)
@crankyoldgit crankyoldgit mentioned this issue Apr 9, 2020
Merged
crankyoldgit added a commit that referenced this issue Apr 9, 2020
@crankyoldgit
v2.7.5 Release (#1077)
ba0d84a 
_v2.7.5 (20200409)_

**[Features]**
- Detailed support for `HITACHI_AC1` protocol. (#1056, #1061, #1072)
- update sharp to match Sharp AH-A5SAY (#1074)
- Experimental support for AIRWELL protocol. (#1069, #1070)
- SamsungAC: Add Breeze (Aka WindFree) control (#1062, #1071)
- Support for Daikin FFN-C A/C (#1064, #1065)
- Add basic support for HITACHI_AC3 protocol. (#1060, #1063)
- Add support for `SYMPHONY` 11 bit protocol. (#1057, #1058)
- IRMQTTServer: Improve Home-Assistant discovery by sending a 'device' with the discovery packet (#1055)

**[Misc]**
- Clean up support status of various protocols.
- Add `decodeToState()` unit tests to all supported protocols (#1067, #1068)
- Add Gree AC example code. (#1066)
@crankyoldgit
Copy link
Owner Author

FYI, This has been included in the new v2.7.5 release of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crankyoldgit crankyoldgit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add decodeToState() unit tests to all supported protocols crankyoldgit/IRremoteESP8266
1 participant
@crankyoldgit