-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can help join HITACHI RAS series remote (346 bit) #1134
Comments
I use auto_analyse_raw_data.py program in the tools directory to decode it. [Power off / Coll / Celsius:27 / Fan: min (min / low / mid / hi) ]Found 691 timing entries. Guessing encoding type: Guessing key value: Decoding protocol based on analysis so far: kHdrMark+kHdrSpace+10000000000010000000000000000010111111011111111100000000001100111100110000011001111001101100100000110111001101101100100100000000111111110000000011111111000000001111111100000000111111110000000011111111110010000011011110000111011110000000000011111111000000001111111100000001111111101100000000111111000001001111101100000000111111110000000011111111 Total Nr. of suspected bits: 344 |
- Add `sendHitachiAc344` method. - Extend `decodeHitachiAc()` to handle 344 bits. - Unit test coverage (and improvements) For #1134
- Add `sendHitachiAc344` method. - Extend `decodeHitachiAc()` to handle 344 bits. - Unit test coverage (and improvements) For #1134
FYI, the latest |
dear @crankyoldgit these days, I have spent some time creating this, https://docs.google.com/spreadsheets/d/1LPd8K9V437oyEMZT6JDv5LlPXh61RPmgeoVcHLWWr7k/edit?usp=sharing |
Thanks. I've had a look at the spreadsheet. This is as per: https://github.com/crankyoldgit/IRremoteESP8266/wiki/Adding-support-for-a-new-AC-protocol#create-a-spreadsheet |
ok, i will do this. Thanks. |
I use newest 'auto_analyse_raw_data.py' in the tools directory to decode it. |
No, I'm suggesting you use the latest
Hexadecimal is probably easiest for you when using |
As per our discussion, use IRrecvDumpV2 with latest version of th master branch to capture. |
Thanks. Looks good. I'll try to start on this tomorrow. |
Thank you for your help! |
* **[Breaking change]** Moved `state[]` to LSB First ordering. * Hitachi344 appears to just be a shorter version of Hitachi424, so using class inheritence to reduce code space. * Update Hitachi424 class to allow virtual methods. * Add unit test coverage. * Add common IRac API support. Fixes #1134 (Hopefully)
Good news, this protocol appears to be just a shorter version of Bad news, is that in order to re-use the code, I had to change the bit ordering to LSB First order. Can you please download PR #1147 / Branch https://github.com/crankyoldgit/IRremoteESP8266/tree/Hitachi344detailed and let us know if it works okay? |
ok, I will test and report back immediately. |
Looking forward to it. |
* Fix the stateReset() so that we can recreate a message state correctly. * More unit tests. Fixes #1134
FYI, I've updated that branch for increased compatibility when using the class methods. |
Hi, @crankyoldgit the test results below: Protocol: [HITACHI_AC_344 | HITACHI_AC_424] - work All in all, it is almost controllable. |
Thanks for testing and coming back with feedback.
Okay, I'll look into why that isn't working tomorrow.
Correct. They are not (yet) supported. If you want them to work, you'll need to supply data and analysis. |
It already can control on / off, i can control modes off option to turn off. |
I'm not sure what you're saying here. Can you please explain the entire situation again? Your comments seem conflicting to me. |
Sorry, These two days are not at home because of work. |
Cool. Didn't mean to rush you. Looking forward to your feedback. |
@crankyoldgit Power, Mode, Temp and Fan are working at HITACHI_AC_344 & HITACHI_AC_424 protocol. But the swinging behavior is as follows: HITACHI_AC_344 - Swing(V) (Off | Auto) are working, Swing(V) (Highest | High | Middle | Low | Lowest) no function(air conditioner controller haven't this option). Sorry to keep you waiting. |
I assume you mean 424 for these? |
oh, i'm sorry, i mean... HITACHI_AC_344 - Swing(V) are all not working . HITACHI_AC_424 - Swing(V) (Off | Auto) are working, Swing(V) (Highest | High | Middle | Low | Lowest) no function(air conditioner controller haven't this option). |
I'll look into that. (start with all swings "off"/middle etc)
That should hopefully give me the data to make it work successfully. (Fingers crossed) Re: The rest. That sounds correct as far as what is implemented. [Q] You keep listing both the 344 & 424 versions. Do you have two AirCon units, one of each?! |
`
OK, i will capture that and report quickly.
No, i only have 1 AirCon units, i report 344 & 424 just because I found that 424 protocol option can also control my AirCon. :D |
@crankyoldgit, |
@leo12757 I've had a look at the data, thanks for that! There are a couple of possibilities on how to fix it. This is attempt number 1. I've updated the PR & branch. |
Okay, I will test it and still download the Hitachi344Swing branch, right?
Can you explain this part in detail, I am not as professional as you :’D |
Correct.
It may be the case that the way I've "fixed" it may cause the Vertical Swing to swap from on to off, and off to on with each each message IRMQTTServer sends to it.
There are two parts in the data that might cause swingV to be on. Depending how they actually control the unit, it could now accidentally keep triggering a change of swingV mode. I've taken a 50/50 chance with how it works. I need you to confirm if the solution works, or if I need to go to "Plan B". That clearer? |
I get it, thanks for your explanation, I start testing and report. |
@crankyoldgit , |
Sorry, I don't get what you're saying here. Is this what it is doing, or is this what you think it should be doing? (I know English isn't your natural language, but unfortunately what your saying isn't clear) Please remember, I can't see what your a/c is doing in response to what ever settings (and sequence) you've told it. You have to document everything, and make it clear. |
Ideally, when IRMQTTServer says swingV is NOT |
Sorry, I explain clearly, I hope: But in fact is below: Thank you for your patience. :D |
Okay, I've uploaded another attempted fix to that branch, please download & try it now. |
@crankyoldgit i haved test, this report below: I think the right behavior is: It look like that the lase Hitachi344Swing version was correct for the swing V when the air conditioner was Off->Cool, but the problem is can't turn off swing V reasonable. Thank you. |
Okay. New fix attempt uploaded. It should now try to use the same method as Hitachi424 which you indicated was working on your device. Download it as usual and let me know how it goes. |
ok, i will test and report quickly. |
@crankyoldgit |
Excellent (for you). It's ugly for me, I got it working doing some really horrible stuff. Oh well, it works. That's the main thing. |
* Hitachi344: Add Swing(H) and improve Swing(V) * Correct Swing(V) control * Add Swing(H) support. * Update common A/C support. * Reduce duplicate code between 344 & 424 classes. * add & update supporting Unit Tests. * Update supported models * Improve doxygen comments. * Fix typo Fixes #1134
FYI, the code & changes referenced above have been included in the v2.7.8 release of the library. |
My air conditioner is Hitachi RAS-22NK, which is unrecognizable, can help to join?
Thanks.
Version of the library : 2.7.2
###[Power On / cool / Celsius: 26 / Fan: min (min / low / mid / hi) ]###
Protocol : UNKNOWN
Code : 0x919B8582 (346 Bits)
uint16_t rawData[691] = {3410, 1624, 482, 1226, 458, 464, 458, 462, 456, 464, 460, 460, 462, 460, 460, 462, 460, 460, 460, 462, 460, 462, 456, 466, 458, 462, 456, 1228, 462, 460, 460, 462, 460, 462, 458, 462, 456, 466, 456, 464, 458, 464, 456, 466, 460, 460, 460, 462, 460, 460, 458, 464, 456, 464, 458, 464, 456, 464, 460, 462, 454, 466, 458, 1226, 460, 462, 456, 1226, 456, 1230, 456, 1228, 456, 1230, 458, 1228, 456, 1228, 456, 464, 456, 1230, 454, 1230, 458, 1228, 458, 1226, 454, 1230, 454, 1230, 454, 1230, 458, 1228, 458, 1230, 452, 468, 456, 464, 454, 468, 456, 464, 418, 502, 456, 466, 458, 464, 458, 462, 458, 464, 454, 468, 456, 1230, 454, 1230, 454, 466, 456, 464, 456, 1228, 456, 1230, 456, 1230, 456, 1230, 456, 464, 458, 464, 458, 1228, 456, 1230, 456, 464, 454, 466, 456, 466, 456, 464, 458, 462, 458, 1228, 458, 1228, 458, 464, 454, 468, 456, 1228, 458, 1228, 458, 1228, 456, 1228, 456, 464, 454, 468, 456, 1228, 458, 1226, 458, 464, 458, 1226, 456, 1230, 454, 468, 458, 462, 452, 1232, 460, 462, 458, 460, 460, 462, 456, 466, 458, 462, 456, 1230, 456, 1228, 460, 462, 460, 1226, 458, 1228, 458, 1226, 460, 460, 456, 468, 458, 464, 456, 1226, 460, 462, 458, 1228, 456, 1228, 458, 462, 462, 1224, 460, 1226, 458, 1226, 460, 464, 458, 1228, 456, 462, 460, 462, 460, 1226, 460, 460, 462, 460, 458, 462, 458, 462, 456, 464, 460, 460, 462, 460, 462, 460, 460, 1224, 462, 1224, 462, 1224, 458, 1226, 462, 1224, 460, 1224, 400, 1284, 446, 1240, 446, 476, 458, 462, 464, 458, 462, 460, 460, 460, 458, 462, 462, 462, 456, 464, 460, 1226, 460, 1226, 460, 1224, 462, 1224, 460, 1224, 460, 1224, 460, 1224, 462, 1224, 462, 460, 460, 462, 460, 460, 458, 464, 458, 462, 458, 464, 458, 462, 460, 460, 462, 1224, 460, 1226, 458, 1228, 456, 1226, 462, 1222, 460, 1228, 458, 1226, 460, 1226, 460, 460, 458, 462, 460, 462, 460, 460, 460, 462, 460, 462, 458, 464, 460, 458, 460, 1226, 456, 1228, 462, 1224, 460, 1224, 458, 1228, 458, 1226, 458, 1228, 462, 1224, 460, 462, 460, 462, 458, 464, 460, 460, 456, 466, 458, 462, 460, 460, 462, 458, 460, 1224, 460, 1224, 458, 1226, 460, 1224, 460, 1226, 460, 1226, 458, 1228, 456, 1230, 456, 1228, 462, 1224, 460, 460, 458, 462, 458, 1228, 456, 466, 458, 462, 454, 468, 458, 462, 458, 462, 460, 1226, 456, 1228, 458, 464, 420, 1264, 458, 1228, 458, 1228, 456, 1228, 454, 468, 456, 464, 456, 466, 456, 1228, 460, 1226, 456, 1230, 456, 1228, 456, 464, 456, 1230, 458, 1226, 458, 1226, 452, 468, 456, 466, 376, 546, 456, 466, 456, 464, 456, 466, 458, 464, 458, 464, 456, 466, 424, 496, 456, 464, 416, 504, 454, 1230, 454, 1232, 456, 1228, 456, 1228, 456, 1230, 456, 1230, 454, 1230, 460, 1226, 426, 496, 424, 496, 456, 466, 374, 546, 454, 468, 374, 544, 458, 464, 456, 464, 458, 1228, 424, 1262, 454, 1232, 426, 1258, 458, 1228, 426, 1260, 454, 1230, 456, 1228, 426, 496, 374, 546, 426, 494, 426, 496, 424, 496, 426, 496, 424, 496, 456, 1230, 456, 1230, 456, 1228, 458, 1228, 456, 1230, 456, 1230, 456, 1230, 424, 1260, 458, 464, 426, 1258, 456, 1230, 422, 500, 456, 466, 418, 504, 424, 496, 426, 496, 456, 464, 420, 500, 454, 468, 456, 1230, 424, 1260, 420, 1264, 422, 1264, 418, 1266, 420, 1264, 420, 500, 456, 466, 426, 494, 454, 468, 456, 464, 420, 1266, 452, 470, 454, 466, 374, 1310, 456, 1228, 456, 1230, 452, 1232, 420, 1266, 424, 498, 456, 1230, 456, 1230, 456, 466, 450, 470, 456, 464, 376, 546, 456, 466, 422, 498, 426, 496, 458, 464, 424, 1260, 454, 1232, 454, 1232, 454, 1232, 458, 1228, 422, 1262, 456, 1228, 454, 1230, 456, 468, 416, 504, 422, 498, 424, 498, 454, 466, 456, 466, 422, 500, 456, 466, 374, 1310, 418, 1266, 424, 1262, 422, 1262, 376, 1310, 376, 1308, 422, 1264, 424, 1262, 350}; // UNKNOWN 919B8582
###[Power On / cool / Celsius: 27 / Fan: min (min / low / mid / hi) ]###
Protocol : UNKNOWN
Code : 0x69C87D5C (346 Bits)
uint16_t rawData[691] = {3352, 1704, 404, 1284, 402, 518, 402, 518, 402, 518, 402, 520, 402, 518, 402, 518, 446, 474, 402, 518, 402, 522, 400, 518, 402, 520, 402, 1282, 444, 476, 402, 518, 404, 518, 404, 518, 402, 548, 372, 518, 402, 520, 402, 518, 402, 520, 402, 518, 404, 518, 402, 520, 402, 518, 402, 520, 400, 518, 404, 518, 402, 518, 402, 1282, 404, 518, 404, 1282, 402, 1284, 400, 1282, 402, 1284, 444, 1240, 450, 1238, 402, 518, 402, 1282, 402, 1282, 402, 1284, 402, 1282, 448, 1236, 404, 1282, 402, 1282, 402, 1282, 404, 1284, 402, 520, 402, 518, 404, 518, 402, 518, 404, 518, 402, 518, 404, 518, 402, 518, 402, 518, 442, 482, 400, 1282, 402, 1284, 402, 518, 402, 518, 402, 1282, 404, 1286, 398, 1282, 402, 1282, 402, 518, 402, 518, 402, 1282, 404, 1282, 404, 518, 404, 518, 404, 516, 404, 518, 402, 518, 404, 1284, 402, 1282, 404, 520, 402, 518, 404, 1282, 404, 1282, 402, 1282, 404, 1282, 404, 520, 402, 518, 402, 1284, 402, 1282, 402, 520, 400, 518, 404, 518, 404, 1282, 404, 520, 402, 518, 404, 520, 400, 1282, 404, 518, 404, 1282, 402, 1282, 404, 518, 404, 1282, 402, 1282, 404, 1282, 402, 518, 404, 1282, 402, 520, 402, 520, 402, 1284, 402, 1282, 404, 518, 402, 1282, 402, 1282, 404, 516, 404, 1282, 402, 1284, 402, 520, 400, 520, 400, 1282, 404, 518, 402, 518, 402, 1282, 402, 518, 402, 520, 402, 518, 404, 520, 402, 518, 404, 520, 402, 518, 404, 518, 404, 1282, 404, 1282, 402, 1282, 402, 1282, 402, 1282, 404, 1282, 404, 1284, 402, 1284, 402, 518, 404, 518, 402, 518, 404, 518, 402, 518, 408, 520, 396, 520, 400, 518, 404, 1282, 404, 1284, 402, 1282, 402, 1282, 402, 1280, 404, 1282, 404, 1282, 446, 1242, 402, 518, 402, 518, 404, 518, 404, 518, 404, 518, 402, 518, 404, 520, 402, 516, 404, 1282, 404, 1286, 400, 1286, 400, 1282, 404, 1280, 448, 1236, 404, 1282, 404, 1282, 444, 478, 402, 522, 400, 518, 452, 470, 404, 516, 452, 472, 402, 516, 450, 472, 402, 1280, 404, 1284, 446, 1236, 404, 1282, 444, 1248, 396, 1280, 404, 1280, 448, 1238, 452, 472, 444, 478, 400, 516, 404, 518, 444, 476, 446, 478, 402, 520, 450, 470, 448, 1236, 444, 1240, 446, 1238, 404, 1282, 446, 1238, 404, 1280, 448, 1238, 404, 1282, 404, 1282, 402, 1282, 404, 518, 402, 520, 402, 1282, 402, 518, 404, 518, 402, 520, 402, 518, 402, 518, 404, 1282, 402, 1284, 428, 518, 402, 1284, 402, 1284, 402, 1282, 404, 1284, 402, 518, 444, 480, 402, 518, 404, 1282, 404, 1282, 404, 1282, 404, 1282, 444, 480, 400, 1284, 402, 1284, 402, 1282, 402, 518, 442, 480, 448, 472, 452, 472, 442, 476, 450, 472, 402, 520, 402, 520, 400, 518, 448, 474, 444, 480, 456, 462, 448, 1236, 448, 1236, 448, 1238, 446, 1240, 444, 1240, 450, 1236, 446, 1240, 464, 1222, 402, 518, 450, 472, 450, 472, 458, 462, 450, 472, 444, 476, 462, 460, 462, 460, 462, 1222, 460, 1226, 460, 1224, 462, 1224, 462, 1224, 460, 1224, 462, 1224, 462, 1224, 448, 472, 456, 464, 460, 462, 462, 460, 458, 462, 462, 462, 458, 462, 464, 1222, 460, 1224, 450, 1236, 462, 1224, 462, 1222, 446, 1240, 402, 1284, 446, 1240, 462, 458, 462, 1224, 460, 1226, 460, 460, 488, 434, 460, 462, 462, 460, 462, 460, 460, 460, 464, 460, 460, 460, 456, 1228, 446, 1236, 464, 1226, 462, 1222, 458, 1228, 458, 1226, 460, 462, 460, 460, 460, 462, 462, 460, 460, 460, 460, 1226, 460, 460, 464, 458, 458, 1228, 458, 1226, 460, 1224, 460, 1226, 458, 1226, 460, 460, 462, 1224, 462, 1222, 462, 460, 458, 462, 462, 460, 456, 462, 462, 460, 458, 464, 460, 460, 462, 460, 460, 1226, 460, 1226, 460, 1224, 462, 1224, 460, 1224, 462, 1224, 460, 1224, 462, 1224, 462, 460, 456, 466, 458, 462, 460, 460, 460, 486, 460, 460, 460, 462, 458, 462, 462, 1224, 460, 1226, 458, 1226, 460, 1224, 454, 1230, 460, 1224, 456, 1228, 462, 1224, 372}; // UNKNOWN 69C87D5C
###[Power Off / cool / Celsius: 27 / Fan: min (min / low / mid / hi) ]###
Protocol : UNKNOWN
Code : 0x9CAE483A (346 Bits)
uint16_t rawData[691] = {3324, 1704, 446, 1238, 452, 470, 404, 516, 404, 548, 372, 502, 418, 520, 402, 524, 398, 518, 448, 470, 406, 518, 404, 516, 450, 474, 402, 1284, 400, 548, 372, 524, 402, 514, 406, 516, 448, 474, 448, 474, 452, 468, 404, 520, 402, 520, 402, 518, 404, 518, 404, 516, 406, 548, 420, 474, 446, 472, 442, 478, 404, 532, 390, 1288, 398, 524, 396, 1282, 404, 1280, 446, 1242, 402, 1284, 402, 1280, 406, 1280, 404, 518, 450, 1236, 402, 1288, 396, 1294, 392, 1288, 396, 1288, 440, 1242, 402, 1288, 396, 1288, 398, 1290, 396, 516, 448, 474, 446, 476, 448, 482, 394, 522, 400, 520, 402, 518, 402, 518, 402, 530, 392, 514, 406, 1282, 448, 1234, 404, 526, 396, 518, 404, 1286, 400, 1284, 450, 1232, 448, 1238, 404, 522, 398, 550, 372, 1288, 396, 1280, 406, 516, 450, 480, 396, 520, 402, 522, 400, 516, 404, 1280, 404, 1294, 442, 466, 450, 474, 444, 1242, 404, 1282, 404, 1282, 404, 1282, 452, 474, 422, 470, 426, 1280, 404, 1282, 402, 498, 422, 1282, 402, 1282, 448, 472, 406, 524, 398, 1292, 392, 516, 404, 522, 398, 520, 450, 472, 446, 470, 406, 1280, 404, 1284, 400, 518, 404, 1284, 402, 1284, 400, 1282, 402, 526, 396, 518, 404, 1282, 404, 1282, 402, 518, 454, 1232, 448, 1244, 398, 520, 402, 1282, 404, 1282, 448, 474, 450, 470, 444, 1240, 404, 528, 394, 516, 404, 1280, 406, 526, 394, 518, 446, 474, 450, 472, 454, 468, 404, 520, 400, 520, 402, 526, 396, 1314, 370, 1280, 450, 1240, 402, 1294, 390, 1284, 402, 1286, 398, 1282, 404, 1282, 404, 518, 404, 526, 394, 516, 404, 528, 394, 514, 408, 524, 394, 518, 404, 516, 406, 1282, 404, 1280, 406, 1282, 404, 1284, 400, 1280, 406, 1284, 402, 1288, 398, 1284, 400, 518, 404, 516, 404, 520, 402, 516, 406, 520, 402, 518, 450, 484, 390, 516, 450, 1236, 454, 1232, 404, 1282, 452, 1234, 450, 1234, 450, 1234, 452, 1232, 454, 1234, 450, 472, 446, 472, 452, 472, 444, 474, 452, 470, 404, 518, 448, 470, 406, 518, 404, 1280, 450, 1236, 450, 1236, 448, 1242, 400, 1284, 402, 1280, 404, 1280, 448, 1238, 448, 476, 402, 518, 404, 518, 404, 518, 402, 518, 404, 524, 398, 516, 406, 524, 398, 1284, 400, 1284, 402, 1282, 404, 1290, 394, 1290, 394, 1288, 396, 1286, 400, 1282, 404, 1292, 394, 1290, 396, 516, 404, 524, 442, 1234, 404, 518, 446, 488, 392, 516, 404, 516, 404, 524, 396, 1280, 404, 1282, 446, 476, 404, 1284, 402, 1286, 398, 1286, 398, 1280, 448, 474, 404, 516, 406, 520, 402, 516, 404, 1280, 404, 1282, 404, 1282, 442, 476, 406, 1286, 400, 1286, 400, 1286, 398, 1286, 398, 520, 402, 516, 434, 486, 404, 532, 390, 516, 406, 526, 396, 518, 402, 516, 406, 520, 402, 518, 404, 516, 404, 1286, 398, 1286, 400, 1286, 398, 1280, 404, 1284, 402, 1284, 400, 1284, 402, 1284, 402, 516, 442, 486, 440, 476, 404, 516, 406, 516, 406, 520, 400, 520, 402, 518, 404, 1284, 402, 1282, 404, 1280, 404, 1284, 402, 1286, 400, 1286, 398, 1282, 404, 1282, 404, 516, 404, 522, 400, 522, 400, 520, 402, 522, 398, 516, 406, 518, 404, 1282, 404, 1286, 400, 1284, 400, 1284, 400, 1284, 402, 1282, 402, 1282, 404, 1282, 402, 518, 404, 1284, 402, 1282, 404, 526, 394, 516, 404, 522, 400, 516, 406, 518, 402, 516, 406, 516, 406, 516, 404, 1280, 404, 1282, 402, 1282, 402, 1282, 404, 1282, 404, 1282, 402, 520, 400, 520, 402, 516, 404, 520, 402, 516, 406, 1284, 400, 516, 404, 516, 404, 1280, 404, 1280, 406, 1280, 404, 1282, 404, 1282, 404, 520, 402, 1284, 400, 1284, 400, 516, 404, 516, 406, 518, 404, 518, 404, 522, 400, 518, 402, 518, 404, 518, 404, 1280, 404, 1280, 406, 1282, 404, 1282, 404, 1280, 404, 1286, 398, 1282, 404, 1282, 404, 516, 404, 516, 404, 518, 402, 518, 404, 522, 400, 516, 404, 518, 402, 518, 404, 1282, 402, 1282, 404, 1280, 406, 1282, 404, 1280, 404, 1280, 406, 1280, 404, 1280, 378}; // UNKNOWN 9CAE483A
The text was updated successfully, but these errors were encountered: