Hitachi344: Add Swing(H) and improve Swing(V) #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Correct Swing(V) control * Add Swing(H) support. * Update common A/C support. * Reduce duplicate code between 344 & 424 classes. * add & update supporting Unit Tests. * Fix typo Fixes #1134
|
Will check this more when my head is less mushy, but a quick check didn't see anything. |
NiKiZe
approved these changes
May 28, 2020
|
Note to self: Wait a few days before merging to allow user feedback. |
`test/ir_Hitachi_test.cpp:1968: Tab found; better to use spaces [whitespace/tab] [1]` * Mutter-mutter-cut-n-paste-mutter-mutter-swearword!
NiKiZe
approved these changes
May 31, 2020
|
Confirmed working in #1134 (comment) As the code has evolved a lot since you last reviewed it @NiKiZe I'm requesting a re-review. |
Was expecting it, and didn't do much while it wasn't confirmed working. :D |
NiKiZe
approved these changes
May 31, 2020
crankyoldgit
added a commit
that referenced
this pull request
Jun 22, 2020
_v2.7.8 (20200622)_ **[BREAKING CHANGES]** - Fix Manchester code handling; Increase Airwell to `34` bits. (#1200) **[Bug Fixes]** - Carrier40: Use correct gap value. (#1193) **[Features]** - CarrierAc64: Add detailed support. (#1133) - Add experimental support for Hitachi A/C 344 bit protocol (#1139) - Automatic & full library code/API documentation via Doxygen (#1150 #1154 #1155 #1156 #1158 #1165 #1167 #1169 #1180 #1184 #1189 #1191 #1194 #1195 #1197 #1198) - Hitachi344: Add detailed support and change bit ordering. (#1147) - Add Corona AC Protocol (#1152) - Hitachi344: Add Swing(H) and improve Swing(V) (#1148) - Update auto_analyse_raw_data.py with better code comment sections (#1164) - Add support for Midea24 protocol. (#1171) - Add basic Zepeal protocol support (#1178) **[Misc]** - scrape_supported_devices.py: avoid changes to SupportedProtocols.md (#1140) - auto_analyze nice exit on empty rawdata input (#1141) - Comments update + cleanup (#1143) - Update D_STR_IRRECVDUMP_STARTUP text and comments. (#1144) - Minor code cleanups (#1149) - Update `README.md`'s to point to new API docs. (#1151) - Update "Supports" sections (#1160) - Add a `doxygen` check to CI/Travis. (#1161) - scrape_supported_devices: warn about misplaced or legacy supports sections (#1159) - Add Supports sections to some files (#1163 #1166) - Fix compile error when `DEBUG` is enabled. - Add no-output option and return code on error to scrape_supported_devices - Travis: Add scrape_supported_devices error check - Update auto_analyse_raw_data.py to have a default Supports: section - Treat compiler warnings as errors. (#1174) - Remove `calcLGChecksum()` and use new generic `sumNibbles()` (#1175) - Suppress more potential compiler warnings. (#1179) - Load balance travis tasks to reduce wall clock time. (#1183) - Set PlatformIO's default baudrate to 115200 (#1188) - Some fixes to Doshisha protocol handler - Minor cleanups of Corona and Zepeal - Enable Doxygen warning when the parameters for a function/method/procedure are wrong/missing. (#1196)
crankyoldgit
added a commit
that referenced
this pull request
Jun 22, 2020
_v2.7.8 (20200622)_ **[BREAKING CHANGES]** - Fix Manchester code handling; Increase Airwell to `34` bits. (#1200) **[Bug Fixes]** - Carrier40: Use correct gap value. (#1193) **[Features]** - CarrierAc64: Add detailed support. (#1133) - Add experimental support for Hitachi A/C 344 bit protocol (#1139) - Automatic & full library code/API documentation via Doxygen (#1150 #1154 #1155 #1156 #1158 #1165 #1167 #1169 #1180 #1184 #1189 #1191 #1194 #1195 #1197 #1198) - Hitachi344: Add detailed support and change bit ordering. (#1147) - Add Corona AC Protocol (#1152) - Hitachi344: Add Swing(H) and improve Swing(V) (#1148) - Update auto_analyse_raw_data.py with better code comment sections (#1164) - Add support for Midea24 protocol. (#1171) - Add basic Zepeal protocol support (#1178) **[Misc]** - scrape_supported_devices.py: avoid changes to SupportedProtocols.md (#1140) - auto_analyze nice exit on empty rawdata input (#1141) - Comments update + cleanup (#1143) - Update D_STR_IRRECVDUMP_STARTUP text and comments. (#1144) - Minor code cleanups (#1149) - Update `README.md`'s to point to new API docs. (#1151) - Update "Supports" sections (#1160) - Add a `doxygen` check to CI/Travis. (#1161) - scrape_supported_devices: warn about misplaced or legacy supports sections (#1159) - Add Supports sections to some files (#1163 #1166) - Fix compile error when `DEBUG` is enabled. - Add no-output option and return code on error to scrape_supported_devices - Travis: Add scrape_supported_devices error check - Update auto_analyse_raw_data.py to have a default Supports: section - Treat compiler warnings as errors. (#1174) - Remove `calcLGChecksum()` and use new generic `sumNibbles()` (#1175) - Suppress more potential compiler warnings. (#1179) - Load balance travis tasks to reduce wall clock time. (#1183) - Set PlatformIO's default baudrate to 115200 (#1188) - Some fixes to Doshisha protocol handler - Minor cleanups of Corona and Zepeal - Enable Doxygen warning when the parameters for a function/method/procedure are wrong/missing. (#1196)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Jun 23, 2020
## _v2.7.8 (20200622)_ **[BREAKING CHANGES]** - Fix Manchester code handling; Increase Airwell to `34` bits. (#1200) **[Bug Fixes]** - Carrier40: Use correct gap value. (#1193) **[Features]** - CarrierAc64: Add detailed support. (#1133) - Add experimental support for Hitachi A/C 344 bit protocol (#1139) - Automatic & full library code/API documentation via Doxygen (#1150 #1154 #1155 #1156 #1158 #1165 #1167 #1169 #1180 #1184 #1189 #1191 #1194 #1195 #1197 #1198) - Hitachi344: Add detailed support and change bit ordering. (#1147) - Add Corona AC Protocol (#1152) - Hitachi344: Add Swing(H) and improve Swing(V) (#1148) - Update auto_analyse_raw_data.py with better code comment sections (#1164) - Add support for Midea24 protocol. (#1171) - Add basic Zepeal protocol support (#1178) **[Misc]** - scrape_supported_devices.py: avoid changes to SupportedProtocols.md (#1140) - auto_analyze nice exit on empty rawdata input (#1141) - Comments update + cleanup (#1143) - Update D_STR_IRRECVDUMP_STARTUP text and comments. (#1144) - Minor code cleanups (#1149) - Update `README.md`'s to point to new API docs. (#1151) - Update "Supports" sections (#1160) - Add a `doxygen` check to CI/Travis. (#1161) - scrape_supported_devices: warn about misplaced or legacy supports sections (#1159) - Add Supports sections to some files (#1163 #1166) - Fix compile error when `DEBUG` is enabled. - Add no-output option and return code on error to scrape_supported_devices - Travis: Add scrape_supported_devices error check - Update auto_analyse_raw_data.py to have a default Supports: section - Treat compiler warnings as errors. (#1174) - Remove `calcLGChecksum()` and use new generic `sumNibbles()` (#1175) - Suppress more potential compiler warnings. (#1179) - Load balance travis tasks to reduce wall clock time. (#1183) - Set PlatformIO's default baudrate to 115200 (#1188) - Some fixes to Doshisha protocol handler - Minor cleanups of Corona and Zepeal - Enable Doxygen warning when the parameters for a function/method/procedure are wrong/missing. (#1196)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1134