Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

missing letter at IRrecv.h #1331

Closed
jerabina opened this issue Nov 14, 2020 · 2 comments · Fixed by #1332
Closed

missing letter at IRrecv.h #1331

jerabina opened this issue Nov 14, 2020 · 2 comments · Fixed by #1332
Assignees
@crankyoldgit
Labels
bug

Comments

@jerabina
Copy link

IRremoteESP8266\src\IRrecv.h

DECODE_R6 is supposed to be DECODE_RC6

#if (DECODE_RC5 || DECODE_R6 || DECODE_LASERTAG || DECODE_MWM)
int16_t getRClevel(decode_results *results, uint16_t *offset, uint16_t *used,
uint16_t bitTime, const uint8_t tolerance = kUseDefTol,
const int16_t excess = kMarkExcess,
const uint16_t delta = 0, const uint8_t maxwidth = 3);
#endif

now it can't be compiled with:
build_flags =
-D DECODE_RC6=true
-D SEND_RC6=true
@crankyoldgit crankyoldgit self-assigned this Nov 14, 2020
crankyoldgit added a commit that referenced this issue Nov 14, 2020
@crankyoldgit
[BUG] Typo preventing RC6 from compiling when other protocols disabled.
6bf3651 
Fixes #1331
@crankyoldgit crankyoldgit mentioned this issue Nov 14, 2020
Merged
@crankyoldgit
Copy link
Owner

Thanks for the report! D'oh! Sorry about that. Should be fixed when PR #1332 is reviewed and merged.
A pity you only found it after v2.7.12 was released a day or so ago! Oh well.

crankyoldgit added a commit that referenced this issue Nov 15, 2020
@crankyoldgit
[BUG] Typo preventing RC6 from compiling when other protocols disable…
6748577 
…d. (#1332)

Fixes #1331
crankyoldgit added a commit that referenced this issue Nov 25, 2020
@crankyoldgit
v2.7.13 release
e9b6f32 
_v2.7.13 (20201125)_

**[Bug Fixes]**
- Fix crash when `IRac::sendAc(state_t, *state_t)` called with SAMSUNG_AC & `NULL` (#1341 #1339)
- Mitsubishi112 & 136: `setSwingV()` incorrectly sets mode. (#1337)
- Typo preventing RC6 from compiling when other protocols disabled. (#1332 #1331)

**[Features]**
- Coolix: Improve Sensor(ZoneFollow) and add Vane Step support. (#1340 #1318)

**[Misc]**
- refactor ir_Coolix (#1340)
- refactor ir_Mitsubishi (#1336)
- refactor ir_MitsubishiHeavy (#1333)
@crankyoldgit crankyoldgit mentioned this issue Nov 25, 2020
Merged
crankyoldgit added a commit that referenced this issue Nov 25, 2020
@crankyoldgit
v2.7.13 release (#1343)
d02bc1c 
## _v2.7.13 (20201125)_

**[Bug Fixes]**
- Fix crash when `IRac::sendAc(state_t, *state_t)` called with `SAMSUNG_AC` & `NULL` (#1341 #1339)
- Mitsubishi112 & 136: `setSwingV()` incorrectly sets mode. (#1337)
- Typo preventing RC6 from compiling when other protocols disabled. (#1332 #1331)

**[Features]**
- Coolix: Improve Sensor(ZoneFollow) and add Vane Step support. (#1340 #1318)

**[Misc]**
- refactor ir_Coolix (#1340)
- refactor ir_Mitsubishi (#1336)
- refactor ir_MitsubishiHeavy (#1333)
@crankyoldgit
Copy link
Owner

FYI, the changes mentioned above have now been included in the new v2.7.13 release of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crankyoldgit crankyoldgit

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUG] Typo preventing RC6 from compiling when other protocols disabled. crankyoldgit/IRremoteESP8266
2 participants
@jerabina @crankyoldgit