Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix crash when IRac::sendAc(state_t, *state_t) called with SAMSUNG_AC & NULL #1341

Merged
merged 2 commits into from
Nov 25, 2020

Conversation

crankyoldgit
Copy link
Owner

@crankyoldgit crankyoldgit commented Nov 24, 2020

  • Ensure protocols that use the prev pointer's power state are okay when it's NULL.
  • Add unit test to ensure this doesn't happen again.

Fixes #1339

… ptr and SAMSUNG_AC.

* Ensure protocols that use the`prev` pointer's power state are okay when it's NULL.

Fixes #1339
@crankyoldgit crankyoldgit self-assigned this Nov 24, 2020
@crankyoldgit
Copy link
Owner Author

Xref: arendst/Tasmota#9969

@crankyoldgit crankyoldgit merged commit 71f42c6 into master Nov 25, 2020
@crankyoldgit crankyoldgit deleted the Issue1339 branch November 25, 2020 09:33
crankyoldgit added a commit that referenced this pull request Nov 25, 2020
_v2.7.13 (20201125)_

**[Bug Fixes]**
- Fix crash when `IRac::sendAc(state_t, *state_t)` called with SAMSUNG_AC & `NULL` (#1341 #1339)
- Mitsubishi112 & 136: `setSwingV()` incorrectly sets mode. (#1337)
- Typo preventing RC6 from compiling when other protocols disabled. (#1332 #1331)

**[Features]**
- Coolix: Improve Sensor(ZoneFollow) and add Vane Step support. (#1340 #1318)

**[Misc]**
- refactor ir_Coolix (#1340)
- refactor ir_Mitsubishi (#1336)
- refactor ir_MitsubishiHeavy (#1333)
@crankyoldgit crankyoldgit mentioned this pull request Nov 25, 2020
crankyoldgit added a commit that referenced this pull request Nov 25, 2020
## _v2.7.13 (20201125)_

**[Bug Fixes]**
- Fix crash when `IRac::sendAc(state_t, *state_t)` called with `SAMSUNG_AC` & `NULL` (#1341 #1339)
- Mitsubishi112 & 136: `setSwingV()` incorrectly sets mode. (#1337)
- Typo preventing RC6 from compiling when other protocols disabled. (#1332 #1331)

**[Features]**
- Coolix: Improve Sensor(ZoneFollow) and add Vane Step support. (#1340 #1318)

**[Misc]**
- refactor ir_Coolix (#1340)
- refactor ir_Mitsubishi (#1336)
- refactor ir_MitsubishiHeavy (#1333)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash when calling IRac::sendAc() with SAMSUNG_AC and prev=NULL
2 participants