Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toshiba Heat Pump - Pure mode #1692

Closed
janpfo opened this issue Nov 29, 2021 · 9 comments · Fixed by #1693
Closed

Toshiba Heat Pump - Pure mode #1692

janpfo opened this issue Nov 29, 2021 · 9 comments · Fixed by #1693
Assignees
@crankyoldgit
Labels
enhancement

Comments

@janpfo
Copy link

janpfo commented Nov 29, 2021 •
edited
Loading

I tried to add it myself, but I couldn't solve it.

It looks like it just sets Byte[7] to 0x10 instead of 0x00

Without pure Temp    
  21 0xF20D03FC0140030042 0xF2, 0x0D, 0x03, 0xFC, 0x01, 0x40, 0x03, 0x00, 0x42
  22 0xF20D03FC0150030052 0xF2, 0x0D, 0x03, 0xFC, 0x01, 0x50, 0x03, 0x00, 0x52
  23 0xF20D03FC0160030062 0xF2, 0x0D, 0x03, 0xFC, 0x01, 0x60, 0x03, 0x00, 0x62
       
With pure      
  21 0xF20D03FC0140031052 0xF2, 0x0D, 0x03, 0xFC, 0x01, 0x40, 0x03, 0x10, 0x52
  22 0xF20D03FC0150031042 0xF2, 0x0D, 0x03, 0xFC, 0x01, 0x50, 0x03, 0x10, 0x42
  23 0xF20D03FC0160031072 0xF2, 0x0D, 0x03, 0xFC, 0x01, 0x60, 0x03, 0x10, 0x72
@NiKiZe
Copy link
Collaborator

NiKiZe commented Nov 29, 2021

Where is

Output of raw data from IRrecvDumpV2.ino or V3 (if applicable) ?

You seem to have ignored the issue template?

@crankyoldgit
Copy link
Owner

Also, what is Pure Mode?

@janpfo
Copy link
Author

janpfo commented Nov 29, 2021 •
edited
Loading

Sorry, I don't have the raw data from IRrecvDump.

I tried with the included Climate IR component in EspHome, where I set byte[7] to 0x10, and it turns on Pure mode.

@crankyoldgit Pure Mode is an "air cleaner" mode, where it uses an ionic filter.

Edit: Updated the first post with the correct with/without Pure.

crankyoldgit added a commit that referenced this issue Nov 29, 2021
@crankyoldgit
TOSHIBA_AC: Add Filter setting support. aka. Pure.
e94d468 
* Add `setFilter()` & `getFilter()`.
* Add filter support for Toshiba in `IRAc` class.
* Minor code style/formating cleanup.
* Update & add unit tests for code coverage and verification.

Fixes #1692
@crankyoldgit crankyoldgit mentioned this issue Nov 29, 2021
Merged
@crankyoldgit
Copy link
Owner

@janpfo Can you please download and test the branch https://github.com/crankyoldgit/IRremoteESP8266/tree/Issue1692 / PR #1693 as it should add setFilter()/getFilter() aka. Pure support for Toshiba. Please let us know the results so we can merge this.

Also, is your remote & A/C model numbers listed in:

IRremoteESP8266/src/ir_Toshiba.h

Lines 12 to 24 in 94080aa

// Supports:
// Brand: Toshiba, Model: RAS-B13N3KV2
// Brand: Toshiba, Model: Akita EVO II
// Brand: Toshiba, Model: RAS-B13N3KVP-E
// Brand: Toshiba, Model: RAS 18SKP-ES
// Brand: Toshiba, Model: WH-TA04NE
// Brand: Toshiba, Model: WC-L03SE
// Brand: Toshiba, Model: WH-UB03NJ remote
// Brand: Toshiba, Model: RAS-2558V A/C
// Brand: Carrier, Model: 42NQV060M2 / 38NYV060M2 A/C
// Brand: Carrier, Model: 42NQV050M2 / 38NYV050M2 A/C
// Brand: Carrier, Model: 42NQV035M2 / 38NYV035M2 A/C
// Brand: Carrier, Model: 42NQV025M2 / 38NYV025M2 A/C

If not, please tell us what they are so we can document that the library works with them.

@crankyoldgit crankyoldgit self-assigned this Nov 29, 2021
@crankyoldgit crankyoldgit added enhancement Pending Confirmation Waiting for confirmation from user labels Nov 29, 2021
@janpfo
Copy link
Author

janpfo commented Nov 29, 2021

@crankyoldgit thank you, that was fast!

I can confirm that filter/pure mode works with the updated code!

// Brand: Toshiba, Model: WH-TA01JE remote

@crankyoldgit
Copy link
Owner

I can confirm that filter/pure mode works with the updated code!

Thanks for that.

// Brand: Toshiba, Model: WH-TA01JE remote

Added. What about the A/C unit itself?

@crankyoldgit crankyoldgit removed the Pending Confirmation Waiting for confirmation from user label Nov 29, 2021
@janpfo
Copy link
Author

janpfo commented Nov 29, 2021

RAS-25SKVP2-ND

@crankyoldgit
Copy link
Owner

Thankyou

crankyoldgit added a commit that referenced this issue Nov 29, 2021
@crankyoldgit
TOSHIBA_AC: Add Filter setting support. aka. Pure. (#1693)
187c533 
* Add `setFilter()` & `getFilter()`.
* Add filter support for Toshiba in `IRAc` class.
* Minor code style/formating cleanup.
* Update & add unit tests for code coverage and verification.

Fixes #1692
crankyoldgit added a commit that referenced this issue Dec 31, 2021
@crankyoldgit
v2.8.1 release
8800c3e 
_v2.8.1 (20220101)_

**[Bug Fixes]**
- Arduino ESP32 Core v2.0.2+ crashes due to our timer hack. (#1715 #1715)
- SONY: Fix old Sony CD-Player Remote (12 Bit) (#1714)

**[Features]**
- Add tool to convert protocol & code to raw timing info. (#1708 #1707 #1703)
- Add basic support for COOLIX48 protocol. (#1697 #1694)
- MITSUBISHI_AC: Added support for i-SAVE mode. (#1666)
- TOSHIBA_AC: Add Filter setting support. aka. Pure. (#1693 #1692)
- Airton: Add detailed A/C support. (#1688 #1670)

**[Misc]**
- Add a structured library version number. (#1717)
- Workflows Split UnitTests (#1712)
- Reduce time for workflow/Build (#1709)
- Fix some compiler & linter warnings (#1699 #1700)
- Fujitsu: Update supported A/C models (#1690 #1689 #1702 #1701)
- Remove extra `const` qualifier for char pointer (#1704)
- TCL: Update supported devices. (#1698)
- ESP32-C3: Work around for some C3 specific compiler issues. (#1696 #1695)
@crankyoldgit crankyoldgit mentioned this issue Dec 31, 2021
Merged
crankyoldgit added a commit that referenced this issue Jan 1, 2022
@crankyoldgit
v2.8.1 release (#1719)
c64fa1d 
## _v2.8.1 (20220101)_

**[Bug Fixes]**
- Arduino ESP32 Core v2.0.2+ crashes due to our timer hack. (#1715 #1713 )
- SONY: Fix old Sony CD-Player Remote (12 Bit) (#1714)

**[Features]**
- Add tool to convert protocol & code to raw timing info. (#1708 #1707 #1703)
- Add basic support for COOLIX48 protocol. (#1697 #1694)
- MITSUBISHI_AC: Added support for i-SAVE mode. (#1666)
- TOSHIBA_AC: Add Filter setting support. aka. Pure. (#1693 #1692)
- Airton: Add detailed A/C support. (#1688 #1670)

**[Misc]**
- Add a structured library version number. (#1717)
- Workflows Split UnitTests (#1712)
- Reduce time for workflow/Build (#1709)
- Fix some compiler & linter warnings (#1699 #1700)
- Fujitsu: Update supported A/C models (#1690 #1689 #1702 #1701)
- Remove extra `const` qualifier for char pointer (#1704)
- TCL: Update supported devices. (#1698)
- ESP32-C3: Work around for some C3 specific compiler issues. (#1696 #1695)
@crankyoldgit
Copy link
Owner

FYI, the changes mentioned above have now been included in the new v2.8.1 release of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crankyoldgit crankyoldgit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TOSHIBA_AC: Add Filter setting support. aka. Pure. crankyoldgit/IRremoteESP8266
3 participants
@NiKiZe @janpfo @crankyoldgit