Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TOSHIBA_AC: Add Filter setting support. aka. Pure. #1693

Merged
merged 3 commits into from
Nov 29, 2021
Merged

TOSHIBA_AC: Add Filter setting support. aka. Pure. #1693

merged 3 commits into from
Nov 29, 2021

Conversation

crankyoldgit
Copy link
Owner

  • Add setFilter() & getFilter().
  • Add filter support for Toshiba in IRAc class.
  • Minor code style/formating cleanup.
  • Update & add unit tests for code coverage and verification.

Fixes #1692

@crankyoldgit
TOSHIBA_AC: Add Filter setting support. aka. Pure.
e94d468 
* Add `setFilter()` & `getFilter()`.
* Add filter support for Toshiba in `IRAc` class.
* Minor code style/formating cleanup.
* Update & add unit tests for code coverage and verification.

Fixes #1692
@crankyoldgit crankyoldgit self-assigned this Nov 29, 2021
@crankyoldgit crankyoldgit mentioned this pull request Nov 29, 2021
Closed
@crankyoldgit crankyoldgit added the Pending Confirmation Waiting for confirmation from user label Nov 29, 2021
@crankyoldgit crankyoldgit removed the Pending Confirmation Waiting for confirmation from user label Nov 29, 2021
@crankyoldgit
Copy link
Owner Author

Confirmed working in #1692 (comment)

PtilopsisLeucotis
PtilopsisLeucotis approved these changes Nov 29, 2021
View reviewed changes
Copy link
Collaborator

@PtilopsisLeucotis PtilopsisLeucotis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Approved.

@crankyoldgit
Copy link
Owner Author

Well done! Approved.

Thanks

@crankyoldgit crankyoldgit merged commit 187c533 into master Nov 29, 2021
@crankyoldgit crankyoldgit deleted the Issue1692 branch December 1, 2021 08:20
crankyoldgit added a commit that referenced this pull request Dec 31, 2021
@crankyoldgit
v2.8.1 release
8800c3e 
_v2.8.1 (20220101)_

**[Bug Fixes]**
- Arduino ESP32 Core v2.0.2+ crashes due to our timer hack. (#1715 #1715)
- SONY: Fix old Sony CD-Player Remote (12 Bit) (#1714)

**[Features]**
- Add tool to convert protocol & code to raw timing info. (#1708 #1707 #1703)
- Add basic support for COOLIX48 protocol. (#1697 #1694)
- MITSUBISHI_AC: Added support for i-SAVE mode. (#1666)
- TOSHIBA_AC: Add Filter setting support. aka. Pure. (#1693 #1692)
- Airton: Add detailed A/C support. (#1688 #1670)

**[Misc]**
- Add a structured library version number. (#1717)
- Workflows Split UnitTests (#1712)
- Reduce time for workflow/Build (#1709)
- Fix some compiler & linter warnings (#1699 #1700)
- Fujitsu: Update supported A/C models (#1690 #1689 #1702 #1701)
- Remove extra `const` qualifier for char pointer (#1704)
- TCL: Update supported devices. (#1698)
- ESP32-C3: Work around for some C3 specific compiler issues. (#1696 #1695)
@crankyoldgit crankyoldgit mentioned this pull request Dec 31, 2021
Merged
crankyoldgit added a commit that referenced this pull request Jan 1, 2022
@crankyoldgit
v2.8.1 release (#1719)
c64fa1d 
## _v2.8.1 (20220101)_

**[Bug Fixes]**
- Arduino ESP32 Core v2.0.2+ crashes due to our timer hack. (#1715 #1713 )
- SONY: Fix old Sony CD-Player Remote (12 Bit) (#1714)

**[Features]**
- Add tool to convert protocol & code to raw timing info. (#1708 #1707 #1703)
- Add basic support for COOLIX48 protocol. (#1697 #1694)
- MITSUBISHI_AC: Added support for i-SAVE mode. (#1666)
- TOSHIBA_AC: Add Filter setting support. aka. Pure. (#1693 #1692)
- Airton: Add detailed A/C support. (#1688 #1670)

**[Misc]**
- Add a structured library version number. (#1717)
- Workflows Split UnitTests (#1712)
- Reduce time for workflow/Build (#1709)
- Fix some compiler & linter warnings (#1699 #1700)
- Fujitsu: Update supported A/C models (#1690 #1689 #1702 #1701)
- Remove extra `const` qualifier for char pointer (#1704)
- TCL: Update supported devices. (#1698)
- ESP32-C3: Work around for some C3 specific compiler issues. (#1696 #1695)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PtilopsisLeucotis PtilopsisLeucotis PtilopsisLeucotis approved these changes

@NiKiZe NiKiZe Awaiting requested review from NiKiZe

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Toshiba Heat Pump - Pure mode
2 participants
@crankyoldgit @PtilopsisLeucotis