Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TODO: Check "SEND_XYZ false" doesn't cause compilation errors. #376

Closed
crankyoldgit opened this issue Dec 13, 2017 · 0 comments
Closed

TODO: Check "SEND_XYZ false" doesn't cause compilation errors. #376

crankyoldgit opened this issue Dec 13, 2017 · 0 comments
Assignees
@crankyoldgit

Comments

@crankyoldgit
Copy link
Owner

This is a placeholder issue to follow up on an issue uncovered for SEND_FUJITSU_AC in #373 & #375
Need to check all other protocols (especially A/Cs) and example code etc.

We can leave the unit testing code alone as we control that environment and always want to test everything.
@crankyoldgit crankyoldgit self-assigned this Dec 13, 2017
crankyoldgit added a commit that referenced this issue Dec 14, 2017
@crankyoldgit
Clean up SEND_XYZ/DECODE_XYZ protocol disables.
9f561cf 
- Add the ability to disable sendRaw() for consistency.

Testing compiling most of the examples with:
* All SEND_XYZs set to false
* All DECODE_XYZs set to false
* All SEND_XYZs & DECODE_XYZs set to false

Note: Does not include SEND_FUJITSU_AC changes as they are in
      PR #375

Fixes issue #376
@crankyoldgit crankyoldgit mentioned this issue Dec 14, 2017
Merged
crankyoldgit added a commit that referenced this issue Dec 18, 2017
@crankyoldgit
Clean up SEND_XYZ/DECODE_XYZ protocol disables.
614c372 
- Add the ability to disable sendRaw() for consistency.

Testing compiling most of the examples with:
* All SEND_XYZs set to false
* All DECODE_XYZs set to false
* All SEND_XYZs & DECODE_XYZs set to false

Note: Does not include SEND_FUJITSU_AC changes as they are in
      PR #375

Fixes issue #376
crankyoldgit added a commit that referenced this issue Dec 19, 2017
@crankyoldgit
Clean up SEND_XYZ/DECODE_XYZ protocol disables.
ed343c4 
- Add the ability to disable sendRaw() for consistency.

Testing compiling most of the examples with:
* All SEND_XYZs set to false
* All DECODE_XYZs set to false
* All SEND_XYZs & DECODE_XYZs set to false

Note: Does not include SEND_FUJITSU_AC changes as they are in
      PR #375

Fixes issue #376
crankyoldgit added a commit that referenced this issue Dec 20, 2017
@crankyoldgit
Clean up SEND_XYZ/DECODE_XYZ protocol disables. (#377)
ef7d15f 
- Add the ability to disable sendRaw() for consistency.

Testing compiling most of the examples with:
* All SEND_XYZs set to false
* All DECODE_XYZs set to false
* All SEND_XYZs & DECODE_XYZs set to false

Note: Does not include SEND_FUJITSU_AC changes as they are in
      PR #375

Fixes issue #376
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@crankyoldgit crankyoldgit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@crankyoldgit