Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a compile issue if SEND_FUJITSU_AC is false. #375

Merged
merged 1 commit into from
Dec 20, 2017
Merged

Fix a compile issue if SEND_FUJITSU_AC is false. #375

merged 1 commit into from
Dec 20, 2017

Conversation

crankyoldgit
Copy link
Owner

Issue reported by @arendst in #373 (comment)

The IRFujistuAC class has a send() method that needs to be disabled if SEND_FUJITSU_AC is false.

@crankyoldgit crankyoldgit self-assigned this Dec 13, 2017
This was referenced Dec 13, 2017
Merged
Closed
crankyoldgit added a commit that referenced this pull request Dec 14, 2017
@crankyoldgit
Clean up SEND_XYZ/DECODE_XYZ protocol disables.
9f561cf 
- Add the ability to disable sendRaw() for consistency.

Testing compiling most of the examples with:
* All SEND_XYZs set to false
* All DECODE_XYZs set to false
* All SEND_XYZs & DECODE_XYZs set to false

Note: Does not include SEND_FUJITSU_AC changes as they are in
      PR #375

Fixes issue #376
@crankyoldgit crankyoldgit mentioned this pull request Dec 14, 2017
Merged
@arendst
Copy link

arendst commented Dec 17, 2017

Solution solves the problem. Thnx.

crankyoldgit added a commit that referenced this pull request Dec 18, 2017
@crankyoldgit
Clean up SEND_XYZ/DECODE_XYZ protocol disables.
614c372 
- Add the ability to disable sendRaw() for consistency.

Testing compiling most of the examples with:
* All SEND_XYZs set to false
* All DECODE_XYZs set to false
* All SEND_XYZs & DECODE_XYZs set to false

Note: Does not include SEND_FUJITSU_AC changes as they are in
      PR #375

Fixes issue #376
crankyoldgit added a commit that referenced this pull request Dec 19, 2017
@crankyoldgit
Clean up SEND_XYZ/DECODE_XYZ protocol disables.
ed343c4 
- Add the ability to disable sendRaw() for consistency.

Testing compiling most of the examples with:
* All SEND_XYZs set to false
* All DECODE_XYZs set to false
* All SEND_XYZs & DECODE_XYZs set to false

Note: Does not include SEND_FUJITSU_AC changes as they are in
      PR #375

Fixes issue #376
@crankyoldgit
Copy link
Owner Author

Friendly code review ping.

darshkpatel
darshkpatel approved these changes Dec 20, 2017
View reviewed changes
Copy link
Collaborator

@darshkpatel darshkpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@crankyoldgit crankyoldgit merged commit 96bd4e6 into master Dec 20, 2017
crankyoldgit added a commit that referenced this pull request Dec 20, 2017
@crankyoldgit
Clean up SEND_XYZ/DECODE_XYZ protocol disables. (#377)
ef7d15f 
- Add the ability to disable sendRaw() for consistency.

Testing compiling most of the examples with:
* All SEND_XYZs set to false
* All DECODE_XYZs set to false
* All SEND_XYZs & DECODE_XYZs set to false

Note: Does not include SEND_FUJITSU_AC changes as they are in
      PR #375

Fixes issue #376
@crankyoldgit crankyoldgit deleted the disable_fujitsu branch December 29, 2017 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darshkpatel darshkpatel darshkpatel approved these changes

@rahuljawale rahuljawale Awaiting requested review from rahuljawale

@markszabo markszabo Awaiting requested review from markszabo

Assignees

@crankyoldgit crankyoldgit

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crankyoldgit @arendst @darshkpatel