Allow disabling the use of delay() calls. #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per Issue #430, the use of delay() calls is incompatible with the AsyncWebserver library. Give users of the library a way to send IR messages without the delay() calls which cause it to break the callbacks of AsyncWebserver. This is not without risk as the delay() calls feed the WDT. No delay() calls means the user can easily cause the WDT to reset the ESP8266. Thus the default is to use delay() calls where possible, and make this a compile-time option to try to limit people shooting themselves in the foot.
It's a more descriptive and accurate for what it does.
|
CC'ing @arihantdaga as they will be testing & checking it. Your feedback is welcome. |
|
Confirmed it works in #430 (comment) |
markszabo
approved these changes
May 7, 2018
Merged
crankyoldgit
added a commit
that referenced
this pull request
May 20, 2018
**[Bug Fixes]** - Fix crash in IRMQTTServer when compiled under Arduino IDE. (#455) - Default bit length not set for RCMM in IRMQTTServer example. (#456) - Bad acknowledgements for some A/C protocols in IRMQTTServer example. (#460) **[Features]** - Allow disabling the use of delay() calls. (#450) - Initial support for G.I. Cable protocol. (#458) - Support of Hitachi A/C 13 & 53 byte messages. (#461) **[Misc]** - Auto Analyse Raw Data script converted to Python. (#454)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Issue #430, the use of delay() calls is incompatible with the AsyncWebserver
library. Give users of the library a way to send IR messages without the delay()
calls which cause it to break the callbacks of AsyncWebserver. This is not
without risk as the delay() calls feed the WDT.
No delay() calls means the user can easily cause the WDT to reset the ESP8266.
Thus the default is to use delay() calls where possible, and make this a
compile-time option to try to limit people shooting themselves in the foot.