Initial code to handle Hitachi A/C 13 & 53 byte codes.

[crankyoldgit]

HITACHI_AC1 is basically the same as HITACHI_AC except only 13 bytes long
and a Header Space that is the same length as the Header Mark.

Ref: #453

[markszabo]

One comment, otherwise LGTM :)

[markszabo]

Should we also have a case HITACHI_AC2: result = "HITACHI_AC2"; here?

[crankyoldgit]

Totally. Excellent catch. Thanks.

Fixed plus found a few other subtle trivial omissions. e.g. code that should be included via #defines etc.

PTAL

[arpitshah87]

Hi crankyoldgit,
I am having the same issue mentioned in #461 . I used latest version of library 2.7.1.
Here is my code I used for my Hitachi Series VI AC but did not work.

#include <Arduino.h>
#include <IRremoteESP8266.h>
#include <IRsend.h>
#include <ir_Hitachi.h>

const uint16_t kIrLed = 4; // ESP8266 GPIO pin to use. Recommended: 4 (D2).
IRHitachiAc ac(kIrLed); // Set the GPIO to be used to sending the message

void setup() {
ac.begin();
Serial.begin(115200);
}

void loop() {
Serial.println("Sending...");

// Set up what we want to send. See ir_Daikin.cpp for all the options.
ac.on();
ac.setFan(kHitachiAcFanAuto);
ac.setMode(kHitachiAcAuto);
ac.setTemp(24);
ac.setSwingVertical(false);
// Display what we are going to send.
Serial.println(ac.toString());

// Now send the IR signal.
ac.send();

unsigned char* ir_code = ac.getRaw();
Serial.print("IR Code: 0x");
for (uint8_t i = 0; i < kHitachiAc1StateLength; i++)
Serial.printf("%02X", ir_code[i]);
Serial.println();

delay(5000);
}

Am I missing any settings?
Appreciate your help....

[crankyoldgit]

@arpitshah87 FYI, Please create a new issue via https://github.com/crankyoldgit/IRremoteESP8266/issues/new Don't append to an existing (old) pull request unless there was a problem in it. :-)

I'm going to need more information before I can help you. e.g. What's the output from IRrecvDumpV2 for your remote/AC unit?

Also, note that only HITACHI_AC and HITACHI_AC424 protocols have an "ac" class to support them. (That is, the have the ability to set attributes.) HITACHI_AC1 & HITACHI_AC2 do not as yet.

[arpitshah87]

@crankyoldgit , I am getting the following output.
Protocol : HITACHI_AC1
Code : 0xB2AE4D91F028B80000000020E8 (104 Bits)
uint16_t rawData[211] = {3410, 3342, 430, 1246, 454, 396, 454, 1218, 454, 1220, 454, 396, 454, 394, 482, 1190, 454, 396, 454, 1218, 454, 398, 454, 1218, 454, 396, 456, 1216, 454, 1246, 454, 1220, 454, 396, 454, 394, 482, 1192, 454, 396, 454, 368, 480, 1218, 454, 1220, 454, 396, 454, 1218, 454, 1246, 454, 370, 454, 394, 480, 1218, 428, 396, 454, 396, 480, 368, 456, 1216, 454, 1220, 454, 1246, 454, 1218, 454, 1246, 428, 396, 454, 394, 480, 368, 480, 342, 482, 368, 480, 370, 480, 1192, 454, 396, 454, 1218, 454, 396, 454, 396, 454, 368, 480, 1218, 454, 370, 456, 1244, 454, 1220, 452, 1246, 428, 396, 454, 394, 480, 370, 480, 342, 482, 368, 480, 368, 480, 342, 482, 368, 480, 368, 480, 368, 456, 368, 480, 370, 480, 370, 478, 342, 482, 368, 480, 368, 480, 342, 480, 370, 480, 370, 480, 370, 456, 368, 480, 370, 480, 370, 456, 368, 480, 370, 480, 370, 480, 342, 480, 370, 480, 370, 478, 344, 480, 370, 478, 370, 480, 370, 454, 368, 480, 370, 478, 370, 478, 344, 480, 1220, 452, 370, 454, 396, 476, 374, 456, 394, 456, 368, 478, 1220, 428, 1246, 454, 1218, 454, 398, 454, 1244, 428, 396, 454, 396, 454, 394, 454}; // HITACHI_AC1
uint8_t state[13] = {0xB2, 0xAE, 0x4D, 0x91, 0xF0, 0x28, 0xB8, 0x00, 0x00, 0x00, 0x00, 0x20, 0xE8};

Thanks for your reply I will wait for the "ac" class of HITACHI_AC1.

[crankyoldgit]

You could be waiting a while. Have a read of https://github.com/crankyoldgit/IRremoteESP8266/wiki/Adding-support-for-a-new-AC-protocol to see how you could speed that along. ;-)