Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental support for detailed Samsung AirCon messages. #521

Merged
merged 2 commits into from
Sep 20, 2018

Conversation

crankyoldgit
Copy link
Owner

  • Construction and decoding via IRSamsungAc class.
  • Unit tests covering new code.
  • Update IRrecvDumpV2 example code to reflect new features.
  • Ref: Decoding Samsung AC IR Remote  #505

Notes:
Checksum support needs more data to be certain it is correct.
"Quiet" & "Clean" modes are guesses. May not be correct.

* Construction and decoding via IRSamsungAc class.
* Unit tests covering new code.
* Update IRrecvDumpV2 example code to reflect new features.
* Ref: #505

Note:
  Checksum support needs more data to be certain it is correct.
  "Quiet" & "Clean" modes are guesses. May not be correct.
@crankyoldgit crankyoldgit self-assigned this Sep 12, 2018
@crankyoldgit crankyoldgit added this to the v2.5 milestone Sep 14, 2018
@crankyoldgit
Copy link
Owner Author

Merging after receiving no negative feedback.

@crankyoldgit crankyoldgit merged commit a560e39 into v2.5-dev Sep 20, 2018
@crankyoldgit crankyoldgit deleted the v2.5-dev-samsung-ac-details branch September 20, 2018 04:17
crankyoldgit added a commit that referenced this pull request Sep 20, 2018
## _v2.5.0 (20180919)_

**[Bug Fixes]**
- Fix HTML menu error for GICABLE in IRMQTTServer. (#516)
- Fix Mitsubishi A/C mode setting. (#514)
- Add missing ',' in auto analyse tool generated code. (#513)
- Fix Fujitsu checksum validation. (#501)
- Remove errant Repeat debug statement in IRMQTTServer. (#507)

**[Features]**
- Mitsubishi A/C decode improvements. (#514)
- Basic support for Whirlpool A/C messages. (#511)
- Basic support for Samsung A/C messages. (#512)
- Experimental support for detailed Samsung A/C messages. (#521)
- Experimental support for detailed Coolix A/C messages. (#518)
- Experimental support for Lutron protocol. (#516)
- Calculate and use average values for timings in analysing tool. (#513)

**[Misc]**
- Style change from using #define's for constants to `const kConstantName`.
- Improve the JVC example code.
@crankyoldgit crankyoldgit mentioned this pull request Sep 20, 2018
crankyoldgit added a commit that referenced this pull request Sep 20, 2018
## _v2.5.0 (20180919)_

**[Bug Fixes]**
- Fix HTML menu error for GICABLE in IRMQTTServer. (#516)
- Fix Mitsubishi A/C mode setting. (#514)
- Add missing ',' in auto analyse tool generated code. (#513)
- Fix Fujitsu checksum validation. (#501)
- Remove errant Repeat debug statement in IRMQTTServer. (#507)

**[Features]**
- Mitsubishi A/C decode improvements. (#514)
- Basic support for Whirlpool A/C messages. (#511)
- Basic support for Samsung A/C messages. (#512)
- Experimental support for detailed Samsung A/C messages. (#521)
- Experimental support for detailed Coolix A/C messages. (#518)
- Experimental support for Lutron protocol. (#516)
- Calculate and use average values for timings in analysing tool. (#513)

**[Misc]**
- Style change from using `#define`s for constants to `const kConstantName`.
- Improve the JVC example code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant