-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.5.0 Release #524
Merged
Merged
v2.5.0 Release #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Convert #define's to const declarations based on C++ style guide.
C++ Code style changes
* Calculate and use average values for timings. * Add missing ',' in generated code.
* Extend features to support timers etc. * Expect and utilize the repeat part when decoding message. * More unit tests. [BUG] * Mode setting was incomplete.
* Initial basic support for Whirlpool A/C messages. - Send Whirlpool A/C messages. - Basic decoding of Whirlpool A/C messages. Settings are not decoded. - Add support to IRMQTTServer example code. - Very basic unit tests for send/decoding. Ref: #509
* Basic support for Samsung A/C messages. - Basic send and decode support. i.e. No detailed breakdown/construction. - Unit tests. - IRMQTTServer example code updated to support this. - Placeholder for upcoming Whirlpool A/C support. * Change Samsung A/C to LSBF order. Based on data collected by @Hollako the temp appears in Least Significant Bit First (LSBF) order. Reversing the bit order in each byte to accommodate. Ref #505 * Use matchData()'s LSBF ordering instead of reverseBits().
* sendLutron & decodeLutron added. * Very basic unit tests for Lutron protocol. * IRMQTTServer updated to add Lutron * [BUG] Fix HTML menu error for GICABLE in IRMQTTServer * Based on information in Issue #515 * Note: This is EXPERIMENTAL/ALPHA code. Based off a single message.
matchData() can now handle LSBF order, so remove some unneeded reverseBits() calls.
* Initial checkin of experimental IRCoolixAC class. Most functions are mapped and appear to work. Unit test coverage for the methods involved. Not tested against a real device at all. Ref: #484
* Construction and decoding via IRSamsungAc class. * Unit tests covering new code. * Update IRrecvDumpV2 example code to reflect new features. * Ref: #505 Note: Checksum support needs more data to be certain it is correct. "Quiet" & "Clean" modes are guesses. May not be correct.
## _v2.5.0 (20180919)_ **[Bug Fixes]** - Fix HTML menu error for GICABLE in IRMQTTServer. (#516) - Fix Mitsubishi A/C mode setting. (#514) - Add missing ',' in auto analyse tool generated code. (#513) - Fix Fujitsu checksum validation. (#501) - Remove errant Repeat debug statement in IRMQTTServer. (#507) **[Features]** - Mitsubishi A/C decode improvements. (#514) - Basic support for Whirlpool A/C messages. (#511) - Basic support for Samsung A/C messages. (#512) - Experimental support for detailed Samsung A/C messages. (#521) - Experimental support for detailed Coolix A/C messages. (#518) - Experimental support for Lutron protocol. (#516) - Calculate and use average values for timings in analysing tool. (#513) **[Misc]** - Style change from using #define's for constants to `const kConstantName`. - Improve the JVC example code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2.5.0 (20180919)
[Bug Fixes]
[Features]
[Misc]
#define
s for constants toconst kConstantName
.