IRMQTTServer: Enforce a repeat for all Coolix calls #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My (Midea by the way) AC units at least all need that repeat :-) |
@jimmys01 What is the model number of the head unit and the remote? I can add it to the supported devices section. :) |
|
Brand: Midea |
|
Thanks. Added. |
A user can request 0 repeats for COOLIX message, they probably don't want that as the default use case is a single repeat. Similar to SONY, enforce the limit to save support headaches rather than assume the user knows what they are doing. (Sorry to any power-users who were using this feature. :-) FYI @jimmys01 Ref: #637 (comment)
crankyoldgit
force-pushed
the
coolix_IRac
branch
from
92804b7 to
8b2f9fd
Compare
crankyoldgit
added a commit
that referenced
this pull request
Jun 16, 2019
_v2.6.2 (20190616)_ **[Features]** - Initial support for the ESP32 architecture & boards. (#742) - Add changable GPIO settings to IRMQTTServer. (#730) - IRMQTTServer: Enforce a repeat for all Coolix calls (#752) - Basic DAIKIN 160bit send and decode. (#754) - Add example code for a Smart(er) IR Repeater. (#740) - Enforce Samsung A/C Quiet & Powerful mutual exclusivity. **[Misc]** - IRMQTTServer: Add some memory alloc safety checks. (#749) - Move some ToString() functions to IRac.cpp (#748) - Increase tolerance value for TCL112AC protocol. (#745) - Fix compiler warning in IRutils_test.cpp (#756) - Scrape Supported Protocols and generate SupportedProtocols.md (#755) - Make supported device info more organised. (#753)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Jun 16, 2019
_v2.6.2 (20190616)_ **[Features]** - Initial support for the ESP32 architecture & boards. (#742) - Add changable GPIO settings to IRMQTTServer. (#730) - IRMQTTServer: Enforce a repeat for all Coolix calls (#752) - Basic DAIKIN 160bit send and decode. (#754) - Add example code for a Smart(er) IR Repeater. (#740) - Enforce Samsung A/C Quiet & Powerful mutual exclusivity. **[Misc]** - IRMQTTServer: Add some memory alloc safety checks. (#749) - Move some ToString() functions to IRac.cpp (#748) - Increase tolerance value for TCL112AC protocol. (#745) - Fix compiler warning in IRutils_test.cpp (#756) - Scrape Supported Protocols and generate SupportedProtocols.md (#755) - Make supported device info more organised. (#753)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A user can request
0repeats for COOLIX message, they probably don'twant that as the default use case is a single repeat.
Similar to SONY, enforce the limit to save support headaches rather than
assume the user knows what they are doing.
(Sorry to any power-users who were using this feature. :-)
IRacclass and thus the IRMQTTServer AirCon page, always sent a valid (with 1 repeat) Coolix message.FYI @jimmys01
Ref: #637 (comment)