Fix compiler warning in IRutils_test.cpp #756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the test array >= 8 entries.
To remove the following warning:
```
g++ -isystem ../lib/googletest/googletest/include -DUNIT_TEST -g -Wall -Wextra -pthread -std=gnu++11 -I../src -I. -c IRutils_test.cpp
In file included from IRutils_test.cpp:6:0:
IRutils_test.cpp: In member function ‘virtual void TestResultToRawArray_LargeValues_Test::TestBody()’:
IRrecv_test.h:12:25: warning: comparison is always false due to limited range of data type [-Wtype-limits]
for (uint8_t i = 0; i < c / 8; ++i) { \
^
IRutils_test.cpp:477:3: note: in expansion of macro ‘EXPECT_STATE_EQ’
EXPECT_STATE_EQ(test_data, result, 7);
^
```
crankyoldgit
added a commit
that referenced
this pull request
Jun 16, 2019
_v2.6.2 (20190616)_ **[Features]** - Initial support for the ESP32 architecture & boards. (#742) - Add changable GPIO settings to IRMQTTServer. (#730) - IRMQTTServer: Enforce a repeat for all Coolix calls (#752) - Basic DAIKIN 160bit send and decode. (#754) - Add example code for a Smart(er) IR Repeater. (#740) - Enforce Samsung A/C Quiet & Powerful mutual exclusivity. **[Misc]** - IRMQTTServer: Add some memory alloc safety checks. (#749) - Move some ToString() functions to IRac.cpp (#748) - Increase tolerance value for TCL112AC protocol. (#745) - Fix compiler warning in IRutils_test.cpp (#756) - Scrape Supported Protocols and generate SupportedProtocols.md (#755) - Make supported device info more organised. (#753)
Merged
crankyoldgit
added a commit
that referenced
this pull request
Jun 16, 2019
_v2.6.2 (20190616)_ **[Features]** - Initial support for the ESP32 architecture & boards. (#742) - Add changable GPIO settings to IRMQTTServer. (#730) - IRMQTTServer: Enforce a repeat for all Coolix calls (#752) - Basic DAIKIN 160bit send and decode. (#754) - Add example code for a Smart(er) IR Repeater. (#740) - Enforce Samsung A/C Quiet & Powerful mutual exclusivity. **[Misc]** - IRMQTTServer: Add some memory alloc safety checks. (#749) - Move some ToString() functions to IRac.cpp (#748) - Increase tolerance value for TCL112AC protocol. (#745) - Fix compiler warning in IRutils_test.cpp (#756) - Scrape Supported Protocols and generate SupportedProtocols.md (#755) - Make supported device info more organised. (#753)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the test array >= 8 entries.
To remove the following warning: