Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create fr-FR.h #962

Merged
merged 2 commits into from
Oct 13, 2019
Merged

Create fr-FR.h #962

merged 2 commits into from
Oct 13, 2019

Conversation

Knackie
Copy link
Contributor

@Knackie Knackie commented Oct 11, 2019

Translate locale for French 😄

@crankyoldgit crankyoldgit self-requested a review October 12, 2019 11:21
@crankyoldgit crankyoldgit self-assigned this Oct 12, 2019
@crankyoldgit crankyoldgit added enhancement Hacktoberfest Hacktoberfest participation labels Oct 12, 2019
crankyoldgit
crankyoldgit requested changes Oct 12, 2019
View reviewed changes
Copy link
Owner

@crankyoldgit crankyoldgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks. A few issues/notes/typos etc.

src/locale/fr-FR.h Outdated
#define D_STR_MOVE "Move"
#define D_STR_SET "Mettre"
#define D_STR_CANCEL "Annuler"
#define D_STR_COMFORT "Cpnfort"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be "Confort"? e.g. a typo?

Copy link
Contributor Author

@Knackie Knackie Oct 12, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fault, it's Confort ! sorry

src/locale/fr-FR.h Outdated
#define D_STR_SLOW "Lent"
#define D_STR_AIRFLOW "Ebauche"
#define D_STR_STEP "Etape"
#define D_STR_NA "N/A"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this unchanged, you can remove it.

src/locale/fr-FR.h Outdated
#define D_STR_DOWN "En bas"
#define D_STR_TEMPDOWN D_STR_TEMP " " D_STR_DOWN
#define D_STR_CHANGE "Changement"
#define D_STR_MOVE "Move"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this unchanged, you can remove it.

src/locale/fr-FR.h Outdated
#define D_STR_PROTOCOL "Protocole"
#define D_STR_ON "On"
#define D_STR_OFF "Off"
#define D_STR_MODE "Mode"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this unchanged, you can remove it.

src/locale/fr-FR.h
#define D_STR_FANONLY "Seul_fan"
#define D_STR_DRY "Sec"

#define D_STR_MED "Avec"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't "Avec" -> "With" in English?

src/locale/fr-FR.h
#define D_STR_LO "B"
#define D_STR_LOWEST "Le plus bas"
#define D_STR_RIGHT "Droite"
#define D_STR_MAXRIGHT D_STR_MAX " " D_STR_RIGHT
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are probably going to need to define "D_STR_MAX"
e.g.
#define D_STR_MAX "Max"

src/locale/fr-FR.h Outdated Show resolved Hide resolved
src/locale/fr-FR.h Show resolved Hide resolved
src/locale/fr-FR.h Show resolved Hide resolved
crankyoldgit
crankyoldgit approved these changes Oct 12, 2019
View reviewed changes
Copy link
Owner

@crankyoldgit crankyoldgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@crankyoldgit crankyoldgit merged commit 4b945cc into crankyoldgit:master Oct 13, 2019
crankyoldgit added a commit that referenced this pull request Oct 30, 2019
@crankyoldgit
v2.7.0 Release
537aa30 
_v2.7.0 (20191030)_

**[Bug Fixes]**
- auto_analyse: Fix > 64 bit send code generation. (#976)
- auto_analyse: Fix missing arguments in generated code for send64+ (#972)
- IRsendProntoDemo: Fix compile issue on ESP32 platform. (#938)
- IRMQTTServer: Fix compile error when `MQTT_ENABLE` is false. (#933)

**[Features]**
- Add Hitachi 424 bit A/C support. (#975, #980, #981)
- Experimental detailed support for `DAIKIN152` (#971)
- Mitsubishi 112bit A/C support (#947, #968)
- gc_decode: Adding Support for Decoding codes in raw code format (#963)
- Refactor to use common routines/macros to handle bit manipulation. (#934)
- Use centralised common strings. Saves ~1.5k of program space. (#946)
- Add Internationalisation (i18n) / Locale support. (#946, #955, #966)
  - `de-CH`: Swiss German. (#949, #954)
  - `de-DE`: German. (#946, #950, #952)
  - `en-AU`: English/Australian (Default locale) (#946)
  - `en-IE`: English/Irish (#946)
  - `en-UK`: English/United Kingdom (#946)
  - `en-US`: English/United States (#946)
  - `es-ES`: Spanish. (#953)
  - `fr-FR`: French. (#962)
- Port CI pipeline to PlatformIO (#936)

**[Misc]**
- Add DAIKIN128 & DAIKIN152 to `decodeToState()` (#982)
- auto_analyse: Produce better code when leader is detected. (#977)
- Coolix A/C improvements (#944)
- A/C setRaw/getRaw/stateReset() cleanup. (#967)
- Add documentation on how to use & support the i18n aspects of the library.
- Make travis checks faster. (#957)
- Translate README.md to french (#959)
- Fixed Coolix kCoolixDefaultState (#941)
- Improve generation of list of pio projects. (#940)
@crankyoldgit crankyoldgit mentioned this pull request Oct 30, 2019
Merged
crankyoldgit added a commit that referenced this pull request Oct 30, 2019
@crankyoldgit
v2.7.0 Release (#983)
f9d7e5c 
_v2.7.0 (20191030)_

**[Bug Fixes]**
- auto_analyse: Fix > 64 bit send code generation. (#976)
- auto_analyse: Fix missing arguments in generated code for send64+ (#972)
- IRsendProntoDemo: Fix compile issue on ESP32 platform. (#938)
- IRMQTTServer: Fix compile error when `MQTT_ENABLE` is false. (#933)

**[Features]**
- Add Hitachi 424 bit A/C support. (#975, #980, #981)
- Experimental detailed support for `DAIKIN152` (#971)
- Mitsubishi 112bit A/C support (#947, #968)
- gc_decode: Adding Support for Decoding codes in raw code format (#963)
- Refactor to use common routines/macros to handle bit manipulation. (#934)
- Use centralised common strings. Saves ~1.5k of program space. (#946)
- Add Internationalisation (i18n) / Locale support. (#946, #955, #966)
  - `de-CH`: Swiss German. (#949, #954)
  - `de-DE`: German. (#946, #950, #952)
  - `en-AU`: English/Australia (Default locale) (#946)
  - `en-IE`: English/Ireland (#946)
  - `en-UK`: English/United Kingdom (#946)
  - `en-US`: English/United States (#946)
  - `es-ES`: Spanish. (#953)
  - `fr-FR`: French. (#962)
- Port CI pipeline to PlatformIO (#936)

**[Misc]**
- Add DAIKIN128 & DAIKIN152 to `decodeToState()` (#982)
- auto_analyse: Produce better code when leader is detected. (#977)
- Coolix A/C improvements (#944)
- A/C setRaw/getRaw/stateReset() cleanup. (#967)
- Add documentation on how to use & support the i18n aspects of the library.
- Make travis checks faster. (#957)
- Translate README.md to french (#959)
- Fixed Coolix kCoolixDefaultState (#941)
- Improve generation of list of pio projects. (#940)
@crankyoldgit
Copy link
Owner

FYI, the changes mention above have been included in the v2.7.0 release of the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crankyoldgit crankyoldgit crankyoldgit approved these changes

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement Hacktoberfest Hacktoberfest participation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Knackie @crankyoldgit