Use istio-parameter in manifests (kubeflow#380)

crobby · Feb 25, 2021 · aa294ab · aa294ab
1 parent 04bcce6
commit aa294ab
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/pkg/kfapp/aws/aws.go b/pkg/kfapp/aws/aws.go
@@ -467,10 +467,6 @@ func (aws *Aws) Generate(resources kftypes.ResourceEnum) error {
 		}
 	} else {
 		if pluginSpec.Auth.Cognito != nil {
-			if err := aws.kfDef.SetApplicationParameter("istio", "clusterRbacConfig", "ON"); err != nil {
-				return errors.WithStack(err)
-			}
-
 			if err := aws.kfDef.SetApplicationParameter("istio-ingress", "CognitoUserPoolArn", pluginSpec.Auth.Cognito.CognitoUserPoolArn); err != nil {
 				return errors.WithStack(err)
 			}

diff --git a/pkg/kfconfig/types.go b/pkg/kfconfig/types.go
@@ -844,7 +844,7 @@ func (c *KfConfig) SetApplicationParameter(appName string, paramName string, val
 			"spartakus":                  "spartakus",
 			// AWS Specific
 			"aws-alb-ingress-controller": KfAppsStackName,
-			"istio-ingress":              KfAppsStackName,
+			"istio-ingress":              "istio-ingress",
 		}
 
 		appNameDir, ok := appToStack[appName]