This repository has been archived by the owner on Aug 17, 2023. It is now read-only.
Use istio-parameter in manifests #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
|
/assign @Jeffwan |
PatrickXYS
changed the title
1 task
Jeffwan
reviewed
Jul 24, 2020
pkg/kfapp/aws/aws.go
Outdated
| if err := aws.kfDef.SetApplicationParameter("istio", "clusterRbacConfig", "ON"); err != nil { | ||
| return errors.WithStack(err) | ||
| } | ||
| // Will roll back after istio move to v3 done |
There was a problem hiding this comment.
We don't have to, it depends on if we want to set clusterRbacConfig=ON in kfctl logic or manifests configmap.
|
@jlewi @adrian555 Can you take a look? We should be good to go. |
|
@PatrickXYS if this is good from AWS platform side, please have someone LGTM. I will approve after that. Thanks. |
|
/lgtm |
|
@adrian555 Can you approve the change? Thanks |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adrian555 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
pushed a commit
that referenced
this pull request
Jul 24, 2020
crobby
pushed a commit
to crobby/kfctl
that referenced
this pull request
Feb 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now,
istiocomponent has not moved to V3 yet. Thus, it still useistio-parameterrather thanistio-config.On kfctl side, we have to use
istio-parameternow in V3 changes.Will roll back until
istiomoved to V3.