Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): issue with file uploading #54

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

vorobeyme
Copy link
Contributor

  • add new method for uploading files (crowdin.go)
  • add error handling for nil file (storage.go)

* add new method for uploading files (crowdin.go)
* add error handling for nil file (storage.go)
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 68.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 98.20%. Comparing base (e0bfa3d) to head (7c47ed8).

Files Patch % Lines
crowdin/crowdin.go 61.91% 4 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
- Coverage   98.46%   98.20%   -0.26%     
==========================================
  Files          66       66              
  Lines        2914     2934      +20     
==========================================
+ Hits         2869     2881      +12     
- Misses         25       29       +4     
- Partials       20       24       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@andrii-bodnar andrii-bodnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vorobeyme thank you!

@andrii-bodnar andrii-bodnar merged commit c712963 into crowdin:main Jul 18, 2024
3 checks passed
@andrii-bodnar andrii-bodnar linked an issue Jul 18, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

report add storage method bug
3 participants