fix(storage): issue with file uploading

crowdin/crowdin.go

@@ -198,6 +198,35 @@ func (c *Client) newRequest(ctx context.Context, method, path string, body any,
 	return req, nil
 }
 
+// newUploadRequest creates an upload request.
+func (c *Client) newUploadRequest(ctx context.Context, method, path string, body io.Reader, opts ...RequestOption) (*http.Request, error) {
+	rel, err := url.Parse(path)
+	if err != nil {
+		return nil, err
+	}
+	u := c.baseURL.ResolveReference(rel)
+
+	req, err := http.NewRequestWithContext(ctx, method, u.String(), body)
+	if err != nil {
+		return nil, err
+	}
+
+	req.Header.Set("User-Agent", c.userAgent)
+	req.Header.Set("Authorization", fmt.Sprintf("Bearer %s", c.token))
+
+	for _, opt := range opts {
+		if err := opt(req); err != nil {
+			return nil, err
+		}
+	}
+
+	if req.Header.Get("Content-Type") == "" {
+		req.Header.Set("Content-Type", "application/octet-stream")
+	}
+
+	return req, nil
+}
+
 // do sends an API request and returns the API response.
 func (c *Client) do(r *http.Request, v any) (*Response, error) {
 	resp, err := c.httpClient.Do(r)
@@ -263,6 +292,16 @@ func (c *Client) Post(ctx context.Context, path string, body, v any, opts ...Req
 	return c.do(req, v)
 }
 
+// Upload makes a POST request to the specified path with a file.
+func (c *Client) Upload(ctx context.Context, path string, file io.Reader, v any, opts ...RequestOption) (*Response, error) {
+	req, err := c.newUploadRequest(ctx, "POST", path, file, opts...)
+	if err != nil {
+		return nil, err
+	}
+
+	return c.do(req, v)
+}
+
 // Patch makes a PATCH request to the specified path.
 func (c *Client) Patch(ctx context.Context, path string, body, v any) (*Response, error) {
 	// Body can be a single object or a slice of objects.

crowdin/storage.go

@@ -2,6 +2,7 @@ package crowdin
 
 import (
 	"context"
+	"errors"
 	"fmt"
 	"mime"
 	"net/url"
@@ -31,14 +32,13 @@ type StorageService struct {
 //
 // https://developer.crowdin.com/api/v2/#operation/api.storages.post
 func (s *StorageService) Add(ctx context.Context, file *os.File) (*model.Storage, *Response, error) {
-	mediaType := mime.TypeByExtension(filepath.Ext(file.Name()))
-	if mediaType == "" {
-		mediaType = "application/octet-stream"
+	if file == nil {
+		return nil, nil, errors.New("file is required")
 	}
 
 	res := new(model.StorageGetResponse)
-	resp, err := s.client.Post(ctx, "/api/v2/storages", file, res,
-		Header("Content-Type", mediaType),
+	resp, err := s.client.Upload(ctx, "/api/v2/storages", file, res,
+		Header("Content-Type", mime.TypeByExtension(filepath.Ext(file.Name()))),
 		Header("Crowdin-API-FileName", url.QueryEscape(filepath.Base(file.Name()))),
 	)
 

crowdin/storage_test.go

@@ -151,6 +151,7 @@ func TestStorageService_Add(t *testing.T) {
 			t.Fatalf("Storages.Add failed to open temp file: %v", err)
 		}
 		defer os.RemoveAll(dir)
+		defer file.Close()
 
 		storage, _, err := client.Storages.Add(context.Background(), file)
 		if err != nil {
@@ -164,6 +165,11 @@ func TestStorageService_Add(t *testing.T) {
 		if !reflect.DeepEqual(storage, want) {
 			t.Errorf("Storages.Add returned %+v, want %+v", storage, want)
 		}
+
+		_, _, err = client.Storages.Add(context.Background(), nil)
+		if err == nil {
+			t.Errorf("Storages.Add should return an error, got nil")
+		}
 	}
 }