Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for odd powers of two in sqrt pst #32

Merged
merged 7 commits into from
Mar 10, 2023

Conversation

maramihali
Copy link
Collaborator

No description provided.

@maramihali maramihali requested a review from nikkolasg March 10, 2023 10:28
Copy link
Collaborator

@nikkolasg nikkolasg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks a lot !
A few nitpick but overall, LGTM after this !

src/dense_mlpoly.rs Show resolved Hide resolved
src/sqrt_pst.rs Outdated Show resolved Hide resolved
src/sqrt_pst.rs Outdated Show resolved Hide resolved
src/sqrt_pst.rs Show resolved Hide resolved
update benchmarks and add missing constraints to circuit
@maramihali maramihali merged commit 11d9ba0 into snarkpack-integration Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants