Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding numbers into the big cube icons. #25

Closed
wants to merge 3 commits into from
Closed

Conversation

jfly
Copy link
Member

@jfly jfly commented Jan 30, 2017

(See discussion over on #13.)

You can see this live on http://www.jflei.com/icons/

jsfiddle: https://jsfiddle.net/cgb1Luvu/2/

@keemy
Copy link
Contributor

keemy commented Jan 30, 2017

my vote is no (but like I said before if everyone else wants I'm fine with it, this is just my vote)

the only icon that looks ok is the 5
but I think changing 4 and 5 is pointless (no added clarity imo)
and the 6 and 7 look bad

I'd want to change 6 and 7 if it looked good
I really don't want to change 4 and 5

@jfly
Copy link
Member Author

jfly commented Jan 30, 2017

(cc-ing @FatBoyXPC, @lgarron)

@coder13
Copy link
Member

coder13 commented Jan 30, 2017

I don't really like the 6 and 7 being off center. I'd much rather than me centered if that.

Also: maybe just bold the centers for the odd cubes (5 and 7). 4 and 6 are pretty distinguishable and so are 5 and 7. All you need to do is tell 6 and 7 apart by bolding the center.

@lgarron
Copy link
Member

lgarron commented Jan 30, 2017

Didn't we settle on different ones further down the thread?

@a-Maass
Copy link

a-Maass commented Jan 30, 2017

@lgarron you mean these right? #13 (comment)
I personally like those better, what do you guys think?

@jfly
Copy link
Member Author

jfly commented Jan 30, 2017

@lgarron you mean these right? #13 (comment)

Those are both in my first commit. See https://github.com/jfly/icons/tree/e98a7851ba5f3a930e5578adcf40ffd7dca1554b/svgs/event.

@keemy and I both do not like the unabalanced nature of the 6 here: https://github.com/jfly/icons/blob/e98a7851ba5f3a930e5578adcf40ffd7dca1554b/svgs/event/666.svg. Going only 5 pixels tall allows us to achieve a balanced look.

@keemy and I both do not like the blocky nature of the slanted 7 here: https://github.com/jfly/icons/blob/e98a7851ba5f3a930e5578adcf40ffd7dca1554b/svgs/event/777.svg, so we went with the straight lines.

I really like the sound of @coder13's idea to just make the centers stand out. That might look good. I'm going to try that out now.

@lgarron
Copy link
Member

lgarron commented Jan 30, 2017

@keemy and I both do not like the unabalanced nature of the 6 here: https://github.com/jfly/icons/blob/e98a7851ba5f3a930e5578adcf40ffd7dca1554b/svgs/event/666.svg. Going only 5 pixels tall allows us to achieve a balanced look.

Okay, good to know. No one at #13 commented on that, though?

I have no objections to making #6 shorter, but we should be consistent about whether to center.

@keemy and I both do not like the blocky nature of the slanted 7 here: https://github.com/jfly/icons/blob/e98a7851ba5f3a930e5578adcf40ffd7dca1554b/svgs/event/777.svg, so we went with the straight lines.

What about all the other 7 designs in the thread?
(I just posted a thicker one, since the cubies are about half the size of 4x4x4, anyhow.)

@keemy
Copy link
Contributor

keemy commented Jan 30, 2017

Okay, good to know. No one at #13 commented on that, though?

was literally my first comment "the top of the 6 is bigger than the bottom"

jfly added 3 commits January 30, 2017 14:46
space, instead putting a smaller number at the bottom right.
space, instead putting a smaller number at the bottom right.
@lgarron
Copy link
Member

lgarron commented Jan 31, 2017

was literally my first comment "the top of the 6 is bigger than the bottom"

Ah, that was before I joined the thread.

What about making the 6 shorter, but still centered?

@jfly
Copy link
Member Author

jfly commented Jul 14, 2018

There didn't seem to be an consensus on this, so I'm going to close this PR.

@jfly jfly closed this Jul 14, 2018
@dmint789 dmint789 mentioned this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants