-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding numbers into the big cube icons. #25
Conversation
my vote is no (but like I said before if everyone else wants I'm fine with it, this is just my vote)
|
(cc-ing @FatBoyXPC, @lgarron) |
I don't really like the 6 and 7 being off center. I'd much rather than me centered if that. Also: maybe just bold the centers for the odd cubes (5 and 7). 4 and 6 are pretty distinguishable and so are 5 and 7. All you need to do is tell 6 and 7 apart by bolding the center. |
Didn't we settle on different ones further down the thread? |
@lgarron you mean these right? #13 (comment) |
Those are both in my first commit. See https://github.com/jfly/icons/tree/e98a7851ba5f3a930e5578adcf40ffd7dca1554b/svgs/event. @keemy and I both do not like the unabalanced nature of the 6 here: https://github.com/jfly/icons/blob/e98a7851ba5f3a930e5578adcf40ffd7dca1554b/svgs/event/666.svg. Going only 5 pixels tall allows us to achieve a balanced look. @keemy and I both do not like the blocky nature of the slanted 7 here: https://github.com/jfly/icons/blob/e98a7851ba5f3a930e5578adcf40ffd7dca1554b/svgs/event/777.svg, so we went with the straight lines. I really like the sound of @coder13's idea to just make the centers stand out. That might look good. I'm going to try that out now. |
Okay, good to know. No one at #13 commented on that, though? I have no objections to making #6 shorter, but we should be consistent about whether to center.
What about all the other |
was literally my first comment "the top of the 6 is bigger than the bottom" |
See discussion over on cubing#13.
space, instead putting a smaller number at the bottom right.
space, instead putting a smaller number at the bottom right.
Ah, that was before I joined the thread. What about making the 6 shorter, but still centered? |
There didn't seem to be an consensus on this, so I'm going to close this PR. |
(See discussion over on #13.)
You can see this live on http://www.jflei.com/icons/
jsfiddle: https://jsfiddle.net/cgb1Luvu/2/