Upgrade to next version of gulp-gh-pages.
#47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes shinnn/gulp-gh-pages#117, which we need to fix the broken build. Hopefully upgrading doesn't cause any other issues, for some reason they have not yet marked 0.6 as the `latest` release on npm.js. See https://github.com/shinnn/gulp-gh-pages/issues/129 for more information.
|
I'm willing to approve this so our deploy works again, but I'm not a fan of leaving |
|
I think we should unbreak the build, and this seems like the easiest fix. I'm totally fine with a recurring reminder, and/or even creating an issue on this repo to track this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes shinnn/gulp-gh-pages#117, which we
need to fix the broken build. Hopefully upgrading doesn't cause any
other issues, for some reason they have not yet marked 0.6 as the
latestrelease on npm.js. Seehttps://github.com/shinnn/gulp-gh-pages/issues/129 for more information.