Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gherkin-ruby] Add ruby-head as a allow failures in .travis.yml. #164

Conversation

junaruga
Copy link
Contributor

Summary

Details

Motivation and Context

I want to add ruby-head to Travis as a allow failures for gherkin-ruby.
The motivation and the detail is same with cucumber/cucumber-ruby#1087

How Has This Been Tested?

When I send this PR here, below Travis will test my .travis.yml right?
https://travis-ci.org/cucumber/gherkin-ruby

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@junaruga
Copy link
Contributor Author

My PR work flow is correct?
How can Travis run gherkin/ruby/.travis.yml before the PR is merged?

@aslakhellesoy aslakhellesoy merged commit a3f926f into cucumber:master Mar 21, 2017
@aslakhellesoy
Copy link
Contributor

Thanks @junaruga. Only the top level .travis.yml gets built by travis, so this won't actually get built by Travis until I sync to https://github.com/cucumber/gherkin-ruby which I'll do shortly.

@aslakhellesoy
Copy link
Contributor

The build is passing on ruby-head: https://travis-ci.org/cucumber/gherkin-ruby

I wonder - wouldn't it be a good thing to disallow failures on ruby-head so it can be brought to our attention early and fix any issues? I wouldn't expect it to be that unstable.

@junaruga
Copy link
Contributor Author

@aslakhellesoy thanks. ok I understood it.

I think this logic is not so useful until the new version Ruby's actual preview release.
But this is still better than current situation.
And from my experience I contributed to cucumber-ruby for Ruby 2.4.0, I thought it was useful.

When I tried to do it, cucumber contributes did not have Ruby 2.4.0 environment in local.
It was hard to explain them about the Ruby 2.4.0 issue.

@junaruga
Copy link
Contributor Author

@aslakhellesoy I am working on Fedora Project's Ruby team.
Fedora Project likes to use latest version's package as their RPM package.
It is kind of experimental distribution.

So, I sometimes discover the issue for new version Ruby, as faster than the upstream project members.
One of the merit for this PR is to reduce my work :)

@lock
Copy link

lock bot commented Oct 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants