-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ruby-head as a allow failures in .travis.yml. #1087
Add ruby-head as a allow failures in .travis.yml. #1087
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @junaruga. I agree on fast_finish
and having ruby-head
in build matrix. Good stuff.
Rakefile
Outdated
# Skip Ruby 2.4 until coveralls supports simplecov (>= 0.13.0) | ||
# for Ruby 2.4 compatibility. | ||
# https://rubygems.org/gems/coveralls | ||
if ENV['TRAVIS'] && RUBY_VERSION < '2.4' | ||
ENV['SIMPLECOV'] = 'ci' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about this. What is the advantage in skipping 2.4 coverage? I think having ruby 2.4.0 in allowed failures is not great, but at least is more explicit.
Also, as far as I understand there is also PR open on coveralls
to fix this: lemurheavy/coveralls-ruby#117
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nodo Yeah, actually it does not matter. This is my favorite. But if the cucumber reviewers does not feel it is problem, I do not change the code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nodo yes there is the PR on coveralls
. I am also watching it.
dfe49ea
to
ccb1559
Compare
@nodo I did rebase of my code. and changed commit message, and this PR's title. |
Thanks @junaruga 👍 |
Nice work @junaruga :) |
@nodo @mattwynne :) |
I am gong to send this kind of PR for |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Change Ruby 2.4.0 from allow failures to required.
Details
I changed Ruby 2.4.0 from allow failures to required.
Because this looks better than current "allow_failures".
We can skip Ruby 2.4's coverage until
coveralls
supportssimplecov
(>= 0.13.0) as a dependency package for Ruby 2.4 compatibility.https://rubygems.org/gems/coveralls
I added "ruby-head" as a "allow_failures".
I think this is useful, because we can prepare
cucumber
for next Ruby version 2.5 in advance before it will be released.Adding "ruby-head" as a "allow_failures" is actually practiced by
rspec
andrails
.And this is the secret that they could support Ruby 2.4.0 quickly.
So, I want to add it to
cucumber
too.https://github.com/rspec/rspec-core/blob/master/.travis.yml
https://github.com/rails/rails/blob/master/.travis.yml
fast_finish
option in.travis.yml
is also useful.https://blog.travis-ci.com/2013-11-27-fast-finishing-builds/
Motivation and Context
It looks better than current "allow_failures".
How Has This Been Tested?
We can see if my code is correct on Travis CI.
Screenshots (if appropriate):
Types of changes
Checklist: