Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruby-head as a allow failures in .travis.yml. #1087

Merged

Conversation

junaruga
Copy link
Contributor

Summary

Change Ruby 2.4.0 from allow failures to required.

Details

I changed Ruby 2.4.0 from allow failures to required.
Because this looks better than current "allow_failures".

We can skip Ruby 2.4's coverage until coveralls supports simplecov (>= 0.13.0) as a dependency package for Ruby 2.4 compatibility.
https://rubygems.org/gems/coveralls

I added "ruby-head" as a "allow_failures".
I think this is useful, because we can prepare cucumber for next Ruby version 2.5 in advance before it will be released.

Adding "ruby-head" as a "allow_failures" is actually practiced by rspec and rails.
And this is the secret that they could support Ruby 2.4.0 quickly.
So, I want to add it to cucumber too.

https://github.com/rspec/rspec-core/blob/master/.travis.yml
https://github.com/rails/rails/blob/master/.travis.yml

fast_finish option in .travis.yml is also useful.
https://blog.travis-ci.com/2013-11-27-fast-finishing-builds/

Motivation and Context

It looks better than current "allow_failures".

How Has This Been Tested?

We can see if my code is correct on Travis CI.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Member

@nodo nodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @junaruga. I agree on fast_finish and having ruby-head in build matrix. Good stuff.

Rakefile Outdated
# Skip Ruby 2.4 until coveralls supports simplecov (>= 0.13.0)
# for Ruby 2.4 compatibility.
# https://rubygems.org/gems/coveralls
if ENV['TRAVIS'] && RUBY_VERSION < '2.4'
ENV['SIMPLECOV'] = 'ci'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this. What is the advantage in skipping 2.4 coverage? I think having ruby 2.4.0 in allowed failures is not great, but at least is more explicit.

Also, as far as I understand there is also PR open on coveralls to fix this: lemurheavy/coveralls-ruby#117

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nodo Yeah, actually it does not matter. This is my favorite. But if the cucumber reviewers does not feel it is problem, I do not change the code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nodo yes there is the PR on coveralls. I am also watching it.

@junaruga junaruga force-pushed the feature/travis-ruby-2.4-back-to-required branch from dfe49ea to ccb1559 Compare February 28, 2017 09:42
@junaruga junaruga changed the title Change Ruby 2.4.0 from allow failures to required. Add ruby-head as a allow failures in .travis.yml. Feb 28, 2017
@junaruga
Copy link
Contributor Author

@nodo I did rebase of my code. and changed commit message, and this PR's title.
I removed my modification for Rakefile for your code review.

@nodo
Copy link
Member

nodo commented Feb 28, 2017

Thanks @junaruga 👍

@mattwynne
Copy link
Member

Nice work @junaruga :)

@junaruga
Copy link
Contributor Author

junaruga commented Mar 2, 2017

@nodo @mattwynne :)

@junaruga
Copy link
Contributor Author

junaruga commented Mar 2, 2017

I am gong to send this kind of PR for ruby-head to all the cucumber Ruby related sub projects as much as possible little by little.

@lock
Copy link

lock bot commented Sep 20, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants