add i18n command line options #864
Conversation
| @@ -50,6 +51,14 @@ export default class Cli { | |||
| async run() { | |||
| await validateInstall(this.cwd) | |||
| const configuration = await this.getConfiguration() | |||
| if (configuration.listI18nLanguages) { | |||
There was a problem hiding this comment.
what about passing stdout to the print* methods and let them do the actual writes?
There was a problem hiding this comment.
I think the current interface is simpler to unit test (not that I added unit tests, but just for future) since the methods just return strings. If we kept the current interface, should we rename the methods? Maybe just make them get* methods?
There was a problem hiding this comment.
Good point! get* is better imo, then, yes.
| @@ -36,6 +44,8 @@ export default class ArgvParser { | |||
| .option('--fail-fast', 'abort the run on first failure') | |||
| .option('-f, --format <TYPE[:PATH]>', 'specify the output format, optionally supply PATH to redirect formatter output (repeatable)', ArgvParser.collect, []) | |||
| .option('--format-options <JSON>', 'provide options for formatters (repeatable)', ArgvParser.mergeJson('--format-options'), {}) | |||
| .option('--i18n-keywords <ISO 639-1>', 'list language keywords', ArgvParser.validateLanguage, '') | |||
| .option('--i18n-languages', 'list languages') | |||
There was a problem hiding this comment.
I like the name of those options. I find them better than in cucumber-rb.
|
Thanks for the heads-up @charlierudolph |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
resolves #763
@mattwynne @danascheider I cleaned up the output and use different cli options then ruby in case you are interested.