Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulate Cucumber-JS's new i18n CLI options #1137

Closed
mattwynne opened this issue Jun 29, 2017 · 1 comment · Fixed by #1140
Closed

Emulate Cucumber-JS's new i18n CLI options #1137

mattwynne opened this issue Jun 29, 2017 · 1 comment · Fixed by #1140

Comments

@mattwynne
Copy link
Member

mattwynne commented Jun 29, 2017

Summary

This should be quite a straightforward change for a newcomer.

See cucumber/cucumber-js#864

Expected Behavior

Let's keep things consistent and use the same CLI options as described in https://github.com/cucumber/cucumber-js/blob/7ae990812cf2b583213b871981f9610ca4e5556e/features/i18n.feature

We'd end up with the existing --i18n option being removed, and replaced by:

--i18n-languages
--i18n-keywords <LANG>

Possible Solution

  1. move features//docs/gherkin/language_help.feature to features/cli/i18n.feature to (roughly) mirror where Cucumber-JS keeps the same feature.
  2. update the spec to match the JS options (--i18n-languages and --i18n-keywords <LANG>)
  3. work on lib/cucumber/cli/options.rb and spec/cucumber/cli/options_spec.rb until all the tests pass.

Context & Motivation

Keeping things consistent between implementations.

@lock
Copy link

lock bot commented Oct 24, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant