Add #original_location to Cucumber::Core::Ast::Step and Cucumber::Core::Test::Step #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs. |
stale
bot
added
the
⌛ stale
stale
bot
removed
the
⌛ stale
The intention is to make the location of the OutlineStep easily accessible from a Cucumber::Core::Test::Step.
brasmusson
force-pushed
the
ast-step-original-location
branch
from
1414ea4 to
1984780
Compare
brasmusson
changed the title
brasmusson
added a commit
that referenced
this pull request
Jul 8, 2018
Also update the Changelog.md.
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Sep 23, 2018
## [3.2.0](cucumber/cucumber-ruby-core@v3.1.0...v3.2.0) ### Added * Add the GherkinSourceParsedEvent ([#155](cucumber/cucumber-ruby-core#155) @brasmusson) * Add #original_location to Cucumber::Core::Ast::Step and Cucumber::Core::Test::Step ([#150](cucumber/cucumber-ruby-core#150), [#149](cucumber/cucumber-ruby-core#149) @brasmusson) ### Fixed * Set message and backtrace for undefined result also when skipping (@brasmusson)
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add Cucumber::Core::Ast::Step#original_location.
Details
The intention is to make the location of the OutlineStep easily accessible from the source of a Cucumber::Core::Test::Step.
Motivation and Context
A Test Step from a Scenario Outline has two locations, the location of the Outline Step and the location of the Example Table Row. This is made explicit by the Gherkin compiler in that a Pickle Step has a locations attribute, that in case of that the Pickle Step was compiled from a Scenario Outline contains both the location of the Outline Step and the Example Table Row. The Cucumber-Ruby compiler does not take this into account, the
Ast::Step,Ast::ExpandedOutlineStepandTest::Stepall (through include of theHasLocationmodule) all respond to the#locationmethod to provide one and only one location. In case ofAst::ExpandedOutlineStepandTest::Stepthe location provided is the location of the Example Table Row.Since
Ast::ExpandedOutlineStepandTest::Stephas two equally important locations (neither cannot be deduced from the other), they should in principle not provide a#locationmethod. However since the use of theHasLocationmodule and the#locationmethod is ubiquitous and depended on in many placed. This PR instead introduce a#original_locationonAst::StepandAst::ExpandedOutlineStepso that both the locations of a Test Step from a Scenario Outline can be easily accessible from the source (#source.last) of the Test Step, without first having to determine whether the Test Step comes from a Scenario or a Scenario Outline.Fixes #149.
How Has This Been Tested?
The automated test suite has been extended to verify this behavior.
Types of changes
Checklist: