Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the GherkinSourceParsedEvent #155

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Conversation

brasmusson
Copy link
Contributor

Summary

Add the GherkinSourceParsedEvent

Details

Let the parser issued a GherkinSourceParsedEvent with the Gherkin Document after parsing a feature file.

Motivation and Context

The GherkinSourceParsedEvent is useful for the formatters when the LegacyApi is removed from Cucumber-Ruby (cucumber/cucumber-ruby#1230)

How Has This Been Tested?

The automated test suite has been extended to verify this functionality.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@brasmusson brasmusson force-pushed the gherkin-source-parsed-event branch from 3efb65b to 3946851 Compare July 13, 2018 11:53
@brasmusson brasmusson merged commit 3946851 into master Jul 13, 2018
brasmusson added a commit that referenced this pull request Jul 13, 2018
Also update the Changelog.md.
@brasmusson brasmusson deleted the gherkin-source-parsed-event branch July 13, 2018 12:02
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Sep 23, 2018
## [3.2.0](cucumber/cucumber-ruby-core@v3.1.0...v3.2.0)

### Added

* Add the GherkinSourceParsedEvent ([#155](cucumber/cucumber-ruby-core#155) @brasmusson)
* Add #original_location to Cucumber::Core::Ast::Step and Cucumber::Core::Test::Step ([#150](cucumber/cucumber-ruby-core#150), [#149](cucumber/cucumber-ruby-core#149) @brasmusson)

### Fixed

* Set message and backtrace for undefined result also when skipping (@brasmusson)
@lock
Copy link

lock bot commented Jul 13, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jul 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant