Emulate Cucumber-JS's new i18n CLI options

[aidamanna]

Summary

Emulates Cucumber-JS's new i18n CLI options.
Fixes #1137 and fixes a test.

Details

See issue #1137

Motivation and Context

Keeping things consistent between implementations.

How Has This Been Tested?

Existing tests have been modified to meet the new requirements.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• I've added tests for my code
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

Please review @mattwynne @tooky

[brasmusson]

@aidamanna May I suggest that you edit the pull-request description to include a keyword for closing issues, to automatically close #1137 when this pull-request is merged. For instance changing "Implements issue #1137 and fixes a test." to "Fixes #1137 and fixes a test."

[mattwynne]

Now that this method is shorter, could you swap this logic around round to use a Guard Clause?

i.e.

return indicate_invalid_language_and_exit(lang) if !::Gherkin::DIALECTS.keys.include? lang
list_keywords_and_exit(lang)

[mattwynne]

@aidamanna this is lovely, a great first contribution!

I see that GitHub is warning us there are merge conflicts, due to you and I both fixing the rubocop offences I left behind in scripts/update-history (sorry!).

Can you try rebasing this branch from master and then force pushing it? Give me a shout in Slack if you need a hand doing that.

[mattwynne]

Also, I think if you rebase master the build may go green - I've tagged out the scenario that seems to be flickering / timing-out on JRuby.

[aidamanna]

@mattwynne little refactor done! :)

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.