Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rake task doesn't accept multiple profiles #905

Closed
jasonkarns opened this issue Aug 11, 2015 · 7 comments
Closed

Rake task doesn't accept multiple profiles #905

jasonkarns opened this issue Aug 11, 2015 · 7 comments

Comments

@jasonkarns
Copy link
Contributor

Cucumber can be executed with multiple profiles from the command line by specifying multiple --profile options. This feature is even nicely documented on the wiki:

Even multiple profiles can be specified together.

However, the Rake task presently only accepts a single profile. Thoughts on also allowing the Rake task's profile argument to accept an array?

Cucumber::Rake::Task.new 'capybara:webkit' do |t|
  t.profile = %w[ capybara webkit ]
end

Which would run:

cucumber  --profile capybara --profile webkit
@jasonkarns
Copy link
Contributor Author

There's already a workaround for this: specifying both profiles using cucumber_opts, but I would love to see proper support for multiple profiles.

Cucumber::Rake::Task.new 'capybara:webkit' do |t|
  t.cucumber_opts = "-p capybara -p webkit"
end

@jasonkarns
Copy link
Contributor Author

Potential PR for this: master...jasonkarns:rake-multiple-profiles

@mattwynne
Copy link
Member

Can you see if you can work out a way to test this? I don't know this code very well and I'm a nervous about making too many changes to it without tests.

@jasonkarns
Copy link
Contributor Author

Sure. I just wanted to make sure the PR would be received well before I
spent any more time on it.

On Wed, Aug 12, 2015 at 5:55 AM, Matt Wynne [email protected]
wrote:

Can you see if you can work out a way to test this? I don't know this code
very well and I'm a nervous about making too many changes to it without
tests.


Reply to this email directly or view it on GitHub
#905 (comment)
.

@jasonkarns
Copy link
Contributor Author

PR #907 submitted

@jasonkarns
Copy link
Contributor Author

ping @mattwynne . I rebased #907 onto master. it's all green and ready for review

@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants